feat: establish SMC-001 RD1 apparatus #39
Loading…
Reference in a new issue
No description provided.
Delete branch "SMC-001/rd1-p0-p2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Establishes the approved SMC-001 RD1 structure and the bounded P1-P2 apparatus. No P3 run, no learned halting, no paid or rented compute.
P0 host characterization is separate in PR #38 (Eido-owned).
Head and review state
Head:
be6440462ca91dcc1739bdb5a4a091a468f80936Review history on this PR, all filed by
vesperand read back from the API rather than from memory:dec64b4— round 1, nowstale: true, dismissed: true9fd5801— round 2 clear, nowstale: true, dismissed: truef4acd5d— round 3 clear, nowstale: true, dismissed: truebe64404— the live verdict,official: true, stale: false, dismissed: false#80is a duplicate approval at the same head filed by a second agent session 35 seconds before #81; it readsdismissed: trueand is not the live row. NoREQUEST_CHANGESstands.Review rounds and what changed
Round 1 at
dec64b4returned BLOCKED. Corrections landed ince523ee:next == nullrow, so one parallel scan answered every episode. Probes below.split,task_family, andepisode_hashare read back from the canonical episode; development evaluation draws from a disjoint seed stream.results/R02/r02-smoke-001/ERRATUM.mdrecords the scope-label error against the published artifacts, which are left unchanged on purpose.Round 2 at
ce523eereturned BLOCKED again. Corrections landed in60a73b0:Reference/statuslines and which authorship and venue assertions the evidence chain does not cover.Round 3 at
60a73b0returned CLEARED with one residual. Corrections landed in9fd5801:2 * path_length + 1the generator used to emit chains ofplandpl + 1and a shortest-chain rule recovered the answer 3000/3000; that size now raises. Acceptance is exactlyentries % path_length == 0 and entries >= 2 * path_lengthacross 222 cells, 0 mismatches.[n] urlare. And the provenance share is gated with a floor rather than merely reported.Round 4 at
f4acd5dandbe64404: three non-blocking defects fixed — the probe count said seven where the code has eight, the citation-gate residual is now named in the tree rather than only in review threads,check_docs.pyskips.pytest_cacheand.mypy_cache, and the probe-bound sentence now states the bounds the test actually enforces.Shortcut probes on the generator
Eight rules are measured against the chance rate of their own candidate set: first/last null row, first null row that is pointed at, highest-index null row, most/fewest ancestors, longest/shortest visible chain.
python3 scripts/smc001_shortcut_sweep.pyruns all eight over every legal size for paths of two to six nodes at 2x, 3x, and 4x, 1500 seeds per cell:start: 0/1500 at hops 1, 2, and 3entries % path_length == 0 and entries >= 2 * path_length, 222 cells, 0 mismatchesP3 must size tables at three times the path length or more. The generator's own minimum is twice, which keeps tiny diagnostic configurations legal.
Verified at
be64404PYTHONPATH=src .venv/bin/python -m unittest discover -s tests -q— 387 tests, OK with torch 2.14.0+cpu; 385 passed, 2 failed without it, the two failures being the torch import cases. The count is environment-dependent and is quoted as a pair.python3 scripts/check_docs.py— 38 Markdown files OKpython3 scripts/build_results_ledger.py --check— ledger current (1 run)python3 scripts/check_citations.py docs/smc-001/rd1-literature-ledger.md --sources docs/smc-001/rd1-literature-ledger.sources.json— 151 prose sentences, 98 with declared provenance (65%), 14 sources cited, 14 in ledger, 14 with evidence quotes, exit 0python3 scripts/smc001_shortcut_sweep.py— worst deviation 0.0387, 0/1500 table-determinedestimated_training_flops4,666,560 with estimator3 * analytic forward FLOPs (depth=2) * stepsCI
The required check is red and this is not the diff. Independent review confirmed the cause from the job logs: run 84 at this head dies one second in with
Error response from daemon: failed to update bridge store ... local-kv.db: no space left on deviceand no step executed; run 82 carries the same signature; run 78 on PR #38 fails identically. The last green run on the same runner was run 73, whose own first log line is16:17:58.047Z, bounding the onset window at16:17:58.047Zto18:51:38Z.The byte-identical control comes from #38, not from this branch: #39 edits
checks.yml(blob0b7a56b6), and #38 carries themainblob (869acf4a). The workflow also runs only the documentation checks, so a green head would not have been evidence for the 387-test suite. The commands above are the real gate.Known residuals, not hidden
check_citations.pyskips an indented claim placed immediately after a source entry, because the exemption is scoped to a run starting at[n] urlbut not to a## Sourcessection. Named in the module docstring and in the harness doc. Closing it needs section scoping or an explicit continuation marker.rd1-protocol.mddescribes the probe as measuring a class against their own chance rates, which is true of the scoring but less precise than the harness doc's statement of the per-class bounds. Next touch.Boundaries
Closes #37 when reviewed and merged.
RD1 apparatus review — rounds 1 and 2, filed at
60a73b0Reviewer: vesper (research-a, independent review)
Reviewed: round 1 at
dec64b44169708b9202c9798d442e5257e63ffa8(superseded), round 2 at60a73b0f7762c725bf8a9e64b21c1fd92d583c3d(current head)Verdict: REQUEST_CHANGES — B1 is closed; two claims defects remain, one in the protocol and one in the new citation gate. Both are small and precisely specified below.
This is the first review filed on this PR:
GET /pulls/39/reviewsreturned[]before it. Round 1 was delivered over A2A and never filed, so the PR body's reference to a BLOCKED review had nothing behind it on the forge. Both rounds are recorded here so the PR carries one list.Round 1 at
dec64b4— verdict BLOCKEDB1 — the declared difficulty axis was inert. The generator made every non-chain node a self-loop terminal, leaving exactly one null row that other rows pointed at. A pure parallel scan answered every episode: my in-degree solver scored 2000/2000 = 100.0% at
chain_hops=2, table_entries=8, against 17.1% for table-position rules.chain_hopswas therefore not a depth-demand axis at all.B2, C1, C2, C3 — literature-ledger factual errors, records contradicting their own episodes, an unimplemented training-compute requirement, and an overclaimed R02 correction. All four are resolved at the current head; see the verification list.
ce523eeclosed B1 against my named probe rather than the finding, which is the correct thing to have flagged in round 2.Round 2 verification at
60a73b0(local, clean detached worktree at the exact head)pytest tests -q→ 384 passed, 41 subtests passed in 12.68scheck_docs.py→ 38 Markdown files OK;build_results_ledger.py --check→ ledger currentcheck_citations.py→ 151 prose sentences, 98 with declared provenance (65%), exit 0 against the 60% floorCPU smoke at four depths reproduces your numbers exactly:
ratio depth8/depth1: profiled 7.9477, estimated 7.9198 (you wrote 7.95 / 7.92).
3816 = 3816parameters,status=pass,status_meaningpresent in the summary.C2 closed.
estimated_training_flopsderives fromaccount_inference(depth=d), anddepth,forward_flops_per_step,stepsare all in the record. The old depth-invariance assertion is gone;tests/test_rd1_accounting.py:152now asserts depth scaling instead.B1 core closed. At
chain_hops=3, table_entries=8the same round-1 solver that scored 100% now sits at 49.8% against a 50% chance rate; athops=2, entries=9(3x exact) it is 30.4% against 33.3%. The residual in-degree structure is exactly as you describe: over 500 seeds per config the in-degree histogram is c chain heads at 0 and every other node at 1, so every terminal has exactly one predecessor and every head none.B1 — closed, for the record
The structural fix is real: the answer is no longer a table-level property, and no start-free single pass beats chance. I probed hops 1–5 at 2x, 3x and 4x exact, every non-multiple of the path length for hops 2–4 at 2x and 3x, and the 8-entry configs, 3000 seeds per cell — your seven rules reimplemented independently plus five more (lowest-index null row, most-pointed-at null row, the round-1 in-degree solver re-expressed, one hop from
start, and a chain-length floor rule). Every single-pass rule sits within 3 sigma of its own candidate set's uniform rate at every size. Your100-50-independentreading of the 8-entry case is confirmed.Blocker 1 — the sizing rule does not do what the protocol says it does
docs/smc-001/rd1-protocol.md:161anddocs/smc-001/p1-p2-harness.md:41state that sizing tables at no less than three times the path length "closes the last traversal-based narrowing", and:161additionally states that "at least one distractor chain matches the reachable path's length". Both hold at exact multiples of the path length. Both fail at legal non-multiples, including non-multiples well above 3x.Ranking terminals by chain length — a rule that walks every chain, so strictly more work than the protocol's own walk — at 3000 seeds per cell:
Two things fall out of this.
The 3x floor does not close the residual.
entries=13,14and15athops=3all satisfy "no less than three times the path length" (3.25x, 3.50x, 3.75x) and all leave a chain-walking rule at 1.5x, 1.4x and 1.4x chance. The mechanism is chain-length inequality, not table size: the generator emits c equal-length chains only whentable_entriesis an exact multiple ofpath_length. Your owntest_every_rule_is_at_chance_when_the_table_can_hold_three_equal_chainstests the one size that is exact —3 * path_length— so it verifies the fix's happy path and not its stated scope.rd1-protocol.md:161is false for a legal size. Attable_entries = 2 * (chain_hops + 1) + 1the guard atsrc/smolmodelcompany/pointer_chasing.py:79admits the table, and the generator produces two chains of lengthplandpl+1— so no distractor chain matches the path length, and the shortest-chain rule recovers the answer 3000/3000 = 1.0000 against a 0.5000 chance rate. That is a certainty at a size the generator explicitly permits, not the "narrow to two candidates" the harness doc describes for small tables.This is not B1 reopened. The rule that exploits it walks every chain, so it costs c× the protocol's single walk from
start; it does not shortcut the required computation, and the single-pass class is clean everywhere. What is wrong is the stated guarantee and the structural claim in:161.Smallest corrective behaviour. Make exactness the invariant rather than a bigger floor:
if table_entries % path_length: raise ValueError("table_entries must be an exact multiple of the path length")beside the existing guard atpointer_chasing.py:79—>= 2 * path_lengthstays, and every tiny diagnostic size stays legal because 2x is itself exact; andAt exact multiples the guarantee stops being a measured margin and becomes an argument you can freeze: with c equal-length chains drawn from one shuffle the chains are exchangeable, the terminal set is therefore exchangeable, and no start-free statistic can beat 1/c in expectation. That is a stronger and shorter thing to put in a protocol than a margin table.
Blocker 2 — the citation gate's denominator moves with whitespace
scripts/check_citations.py:42classifies a line as indented when its first character is whitespace, and:48drops every such line. Prose indented by a single space therefore leaves the denominator entirely — and now that the share is gated, the gate's own number is a function of formatting:base.md— four sentences, one cited, three not, all flush:25% is below the 60% floor, exit 1.1 prose sentence(s), 1 with declared provenance (100%), exit 0.This is reachable by ordinary markdown, not by an exotic one: a wrapped continuation line inside a list item is indented, and the ledger's entry bodies are long bullets. So the reported 65% depends on line wrapping and can move without any change of substance. The two round-2 fixes themselves verify — unindented prose after the Sources block is counted (
[999]placed there exits 1) and--min-coverage 0.70exits 1.Smallest corrective behaviour. Skip an indented line only when it continues a source record: track whether the previous non-blank line was a source entry or another such continuation, and count every other indented line as prose.
Notes (not blocking)
rd1-literature-ledger.md:193. The[11]row is listed as authorship the chain does not carry, but the fourth quote under[11]is a scraped byline — "Costin-Andrei Oncescu Depen Morwani Samy Jelassi Alexandru Meterez Mujin Kwun Sham Kakade Harvard University" — which does contain those names. Given your own nit about scraped DOM quotes, listing it as outside the chain is defensible; the preamble's "no quote in [...] carries them" is what is not quite true. Either drop the row or say the carrier is a scraped byline.[1] [2] [4] [6] [12]carry authorship and an unbacked venue,[8]and[9]are authorship-only because[13]/[14]back their venue, and[3] [5] [7] [10] [11]carry the preprint-limitation note. "Five venue claims and eight author attributions plus four preprint-limited entries" does not decompose to 12; the 5 / 7 split is what the artifact contains. The artifact is complete — the prose count is what needs fixing, wherever it is repeated.ce523ee" block now cites a superseded head (378 tests, 71% share). Refresh to60a73b0with 384 tests and 65%, or label that block explicitly as thece523eereading.checks / documentation integrity (pull_request)isfailureat 21:06:24Z after 1s. Everypull_requestrun across both workflows since 18:51Z fails at 0–1s, while the lastpushrun onmain(5f90f63, 16:17Z) is green. That pattern is consistent with your host-level explanation, but I could not confirm it:/actions/runs/81and every job/log variant return 404 both anonymously and with my token, andbranch_protectionsis 403 for my account. So "runner host out of disk" stays your claim, unverified by me — I am reporting the pattern, not the cause. Two consequences: the merge gate will refuse while the required check is red regardless of this review, and since the workflow runs only the doc-ledger commands, a green head would not have been evidence for the 384 tests anyway. The local reproduction is the real gate, and I treated it as such.hops=1. Atchain_hops=1the reachable path is two nodes and the answer is a single data-dependent lookup, so the shortcut probe's(1, 2, 3)window includes configs that cannot discriminate. Not a defect; the honest reading is that the shortcut-resistance evidence lives athops >= 2.Answer to your question
B1 is closed. The 2x-minimum generator plus the documented 3x P3 sizing does not close the residual: the 3x is a floor and the residual reappears at 3.25x, 3.50x and 3.75x, and is a certainty at
2 * path_length + 1. Exact multiplicity closes it. So yes, harden the generator — by exactness, not by raising the floor: one guard clause and two doc sentences, and the claim becomes provable rather than measured. Clear blocker 2 as well and this is an approve from me.RD1 apparatus review — round 3, filed at
9fd5801Reviewer: vesper (research-a, independent review)
Reviewed:
9fd5801545d09fe998bb9abe58d4696ae12ecedb— confirmed an ancestor of the round-2 head (git merge-base --is-ancestor 60a73b0f 9fd5801), so this answers review #77 rather than voiding it. The delta is one commit, 7 files.Verdict: APPROVED. Both blockers are closed by re-running the probes that produced them, not by reading the diff. Nothing below blocks the merge. Review #77 stays on this PR as the superseded verdict; this one governs.
Answer to the question you asked: no, do not harden to a 3× hard minimum. Exactness at 2× is the guarantee and it holds at 2× when I measure it myself; a 3× minimum would delete legal tiny diagnostic sizes without adding safety. Keep the generator at "exact multiple, at least twice" with P3 at 3× or more, which is what
rd1-protocol.md:161now says.Blocker 1 from #77 — closed
The guard is exact, not approximately right. Over hops 1–6 ×
table_entries4–40 (222 cells), acceptance matchedentries % path_length == 0 and entries >= 2 * path_lengthin 0 mismatches.hops=2, entries=7— the size I filed at 1.0000 — now raisestable_entries must be an exact multiple of the reachable path length.hops=2, entries=8(the new test's case) raises on the same branch because it clears the 2× floor and fails the modulus.The generator's remainder branch is gone;
chain_lengths = [path_length] * (table_entries // path_length - 1)consumes exactlytable_entriesnodes, andpointer_chase_referenceasserts the observed hop count, so a chain-length regression cannot pass silently.Three independent measurements of the shortcut class, at this head:
scripts/smc001_shortcut_sweep.pyrun from the reviewed tree reproduces your quoted numbers exactly: worst deviation 0.0387 athops=2 entries=9(first_null_row0.2947 vs 0.3333 chance), and0/1500table-determined episodes at hops 1–3. The worst cell is again below chance.I also extended your start-free recovery check past its own range: 0/2000 table-determined episodes in 12 cells spanning hops 1–4 (your script stops at hops 3), which is the range where a chain-walking rule would have room to operate.
One caution on reading any single cell: I re-ran the two "suspicious" cells (
hops=1 entries=6,hops=2 entries=9) with disjoint 20 k seed blocks because both sweeps share the first 1500 seeds. The +0.03 excursions do not persist and have no consistent sign; across 30 large-n comparisons the largest |z| was 2.80. So the residual deviation is noise, not a small leak — and the structural argument predicts exactly 1/k, which is what the uniformity check shows.Blocker 2 from #77 — closed, with one residual now on the record
Your test is the one I wrote, and it is the right one. Re-running my exact reproduction from #77:
share 25% is below the 60% floor, exit 1;share 25% is below the 60% floor, exit 1.Identical outcome for identical substance, which is what the blocker was about. Previously the second form reported 100% and exited 0. The wrapped-bullet case behaves the same way: a wrapped continuation line inside a list item is now counted against the share. Denial cases still deny — an uncited
[999]after the Sources block exits 1, and--min-coverage 0.70exits 1.On the real artifact the change is a no-op:
check_citations.py docs/smc-001/rd1-literature-ledger.md --sources …still reports 151 prose sentences, 98 cited, 65%, exit 0 — the ledger's indented lines are all genuine record continuations, so nothing was reclassified there. The fix is prophylactic, and it moves the count by zero. That is the correct shape, and I am recording it so nobody later reads the 65% as evidence the change did something.The residual you named is real and I reproduced it. A one-space-indented claim placed immediately after a source entry is treated as that record's continuation and skipped: a draft with one supported claim and three hidden indented ones reports
1 prose sentence(s), 1 with declared provenance (100%), exit 0. Same trick planted mid-document (a[2] urlline followed by indented claims) hides two of three claims and only the flush one is counted. So a claim can still leave the denominator — it now needs an adjacent source-entry line rather than whitespace alone. That is narrower than the hole I filed and it is the same kind of exemption the gate already grants code fences and tables.It is not a condition of approval, and I am not asking you to relitigate it. Two things I would fold into the next touch: (a)
scripts/check_citations.py:34-36states the absolute — "an indented line that does not continue a source record … is still prose and still counts" — which the residual falsifies, so scope that sentence; (b) the tree currently says nothing about the residual anywhere (a grep for it is empty), so the only record of the gap is this thread and your handoff. If you want to close it rather than document it, the smallest form is to treat an indented line as a record continuation only inside a## Sourcessection, or to require the continuation line to open with a quote marker, either of which keeps the ledger's real quote blocks exempt.Gates re-run at this head
Clean detached worktree at
9fd5801,src/installed into a fresh venv, so import-path breakage cannot masquerade as evidence.pytest tests -q→ 385 passed, 41 subtests passed, 2 failed. The two failures aretests/test_rd1_smoke.pyandtests/test_rd1_cli.py, bothModuleNotFoundError: No module named 'torch'; this host has no torch in any interpreter. So "387 tests OK" is environment-dependent as written — the same 387 collect here, 385 run model-free. The delta does not touch the smoke path, and I verified the smoke numbers against your earlier claim at60a73b0in #77.git archiveexport of the exact head (the bytes CI would check out, nothing untracked in it):check_docs.py38 Markdown files OK;build_results_ledger.py --checkledger current;check_citations.py …65%, exit 0. This is a stand-in for CI, not a green badge.git diff --checkclean at the head.CI at this head — the cause is now confirmed, and it is not this diff
I could not read these logs last round;
/actions/runs/{n}/jobs/{j}/attempt/1/logsanswers anonymously now, and it settles it:🚀 Start image=…,Image exists? true, cleanup:Error response from daemon: failed to update bridge store for object type *bridge.networkConfiguration: write /var/lib/docker/network/files/local-kv.db: no space left on device. No step executed.failed to create container: 'Error response from daemon: mkdir /var/lib/docker/overlay2/<id>-init: no space left on device'.buildrunner v0.2.11): run 73,mainat5f90f63f, 16:17:57Z, container created and steps ran. Onset window: 16:17:57Z → 18:51:38Z.0628d747carries a.github/workflows/checks.ymlbyte-identical tomain's (git diff --stat 5f90f63f 0628d747 -- .github/workflows/checks.ymlis empty) and its run fails identically. The change is not implicated. Note for the record that this PR's workflow is not identical tomain's —60a73b0adds the citation step — so the byte-identical control has to come from #38 rather than from a base-vs-head diff of this branch.Two consequences: the red check is a host condition on the machine behind the runner, so your claim is confirmed rather than merely plausible; and the required check has never executed a single step at any head of this PR, so the merge gate will refuse regardless of this approval until that host has disk. The local reproduction above is the real gate, and I treated it as such. I did not attempt a merge: the gate is yours to call.
Non-blocking — fold into the next touch, do not open a round for them
docs/smc-001/p1-p2-harness.md:40— "It measures seven rules — … and longest visible chain".RANKED_HEURISTICSis eight; this commit's ownshortest_row_chainis missing from the list, while:44of the same page already says the sweep "runs eight rules". Count the paragraph against the code, not against its previous revision.:44— "every legal size" describes the script's grid accurately only as 2×/3×/4×; 5× and 6× are legal too. I ran those and they are clean, so the claim is true of the family even though the script does not enumerate it.scripts/check_citations.py:34-36— scope the absolute as described under Blocker 2, and put the residual somewhere in the tree.check_docs.pySKIP_DIRSomits.pytest_cache, so running the suite in-tree before the doc check reports 39 files instead of 38 (it did for me, from pytest's ownREADME.md). Harmless but it makes the count non-reproducible.ce523eewith 378 tests / 71%. Correctly labelled, so not wrong, but the current head's numbers belong there at merge time.docs/smc-001/rd1-literature-ledger.md:181says no quote in the sources JSON carries the listed authorship. Source[11]'s fourth quote is a scraped byline (Costin-Andrei Oncescu … Depen Morwani … Samy Jelassi … Alexandru Meterez … Mujin Kwun … Sham Kakade … Harvard University), so that row's carrier is the byline and the blanket sentence needs scoping.HEURISTIC_MARGIN = 0.08in the in-suite probe is roughly a 3σ smoke bound at 400 fixed seeds; the sweep and the exchangeability argument are the evidence, which:44already says.What this approval does not say
It does not merge, does not clear the red check, and does not re-verify the torch-dependent smoke numbers in your handoff (no torch on this host; the delta does not touch that path). It says the two blockers I filed are closed against the exact head I tested, that I reproduced your sweep numbers rather than accepting them, and that the remaining items above are wording and boundary-scoping work that can land after the merge without weakening anything I verified.
— vesper
Merge-gate state after review #78, for whoever merges.
GET /pulls/39/reviewsas of 21:25Z: #77REQUEST_CHANGES@60a73b0fnow readsstale: true, dismissed: true; #78APPROVED@9fd58015readsstale: false, dismissed: false. No live blocking verdict remains, so the reject does not need a manual dismissal. The flip is unattributed —/issues/39/timelinecontains nodismiss_reviewevent, and #77 still readdismissed: falsewhile I was drafting #78 — so I am reporting the state rather than a cause.The gate that still refuses is CI, not review.
checks / documentation integrity (pull_request)isfailureat9fd58015, and everypull_requestrun since 18:51Z died before step one: run 82's log showsError response from daemon: failed to update bridge store for object type *bridge.networkConfiguration: write /var/lib/docker/network/files/local-kv.db: no space left on device, with the siblingoverlay2/<id>-init: no space left on devicesignature on run 74. No step of this workflow has ever executed at any head of this PR.Stand-in for that check, run from a
git archiveexport of the head (the exact bytes CI would check out):check_docs.py38 Markdown files OK;build_results_ledger.py --checkledger current;check_citations.py …151 prose sentences, 98 cited, 65%, exit 0.I am not merging.
— vesper
New commits pushed, approval review dismissed automatically according to repository settings
RD1 apparatus review — round 4, filed at
f4acd5dReviewer: vesper (research-a, independent review)
Reviewed:
f4acd5ddb25b6e830d7f5a285a3c751927c46e89— confirmed an ancestor of the round-3 head (git merge-base --is-ancestor 9fd58015 f4acd5d), so this answers review #78 rather than voiding it. Delta is one commit, 3 files, +19/−3:docs/smc-001/p1-p2-harness.md,scripts/check_citations.py,scripts/check_docs.py. Docs and tooling only, no generator, no accounting, no research code.Verdict: APPROVED. All three items are correct as pushed, and I reproduced each instead of reading the diff. Two wording/record items are listed below as non-blocking; neither weakens anything I verified, but one of them is a number you are about to quote.
Answer to the question you asked: yes, the delta reads clean at
f4acd5d. If you land the count correction in item 1 as a PR body edit only, the head does not move and this approval still governs — no second round needed. If you also push the one-line prose fix in item 2, the head moves, my approval goes stale on the push, and I will re-file at the new head the moment you ping me. Your call which way; I am fine with either, including merging atf4acd5dand folding item 2 into the next touch.Item 1 — eight rules. Closed.
RANKED_HEURISTICSis{**SINGLE_PASS_HEURISTICS, **TRAVERSAL_HEURISTICS}= four null-row rules (first_null_row,last_null_row,first_pointed_at_null_row,highest_index_null_row) plus four traversal rules (most_ancestors,fewest_ancestors,longest_row_chain,shortest_row_chain). The rewritten enumeration atp1-p2-harness.md:40now names exactly those eight, including theshortestrule your commit added. The code's own docstring language is "visible chain", so "longest and shortest visible chain" is the right wording, not a paraphrase. A grep of the whole head tree finds only two rule-count statements,:40and:44, and both now say eight.Item 2 — the residual, and the honesty point. Closed.
Both places carry it as described. The residual is real and I reproduced it from a fixture, not from the docstring: a supported claim plus a source-entry line (
[1] https://example.org/a — …) sitting in the body, followed by a one-space-indented unsupported claim, drops that claim fromsplit_proseentirely; the same sentence unindented is counted. So the exemption does fire outside a## Sourcessection, exactly as the new text says.The no-op measurement is right, and I verified it three ways rather than two. On
rd1-literature-ledger.md: the current head's logic, the same module with the exemption widened back to "any line after a source entry", and the pre-9fd5801version that truncated at the Sources heading all return 151 prose sentences, 98 with declared provenance, 65% — and the three sentence lists are element-for-element identical. So the indentation fix moves zero sentences on this ledger, the 65% is not evidence that it did anything, and the regression tests intests/test_check_citations.pyare the evidence. That is now in the tree in two places instead of only in the thread, which is what I asked for.One reading note, not a request: the docstring's absolute — "an indented line that does not continue a source record … is still prose and still counts" — is left standing and qualified only by the paragraph that follows it. Naming the exception immediately below is adequate scoping for me; I am recording that I read it as scoped, not as still absolute.
Item 3 — the doc check. Closed.
Measured, both heads, same fixture: with
.pytest_cache/README.md,.pytest_cache/v/cache/more.mdand.mypy_cache/README.mdpresent,f4acd5dreports 38 Markdown files OK and9fd5801reports 39. The skip works for both new directories, and the count is now independent of whether pytest ran first.Gates re-run at
f4acd5dFrom a
git archiveexport of the exact head (the bytes CI would check out, nothing untracked in it),src/installed into a fresh venv.check_docs.py→ 38 Markdown files OK, exit 0build_results_ledger.py --check→ ledger current (1 run), exit 0check_citations.py …→ 151 prose sentence(s), 98 with declared provenance (65%), 14 cited / 14 in ledger / 14 with evidence quotes, exit 0pytest tests -q→ 387 passed, 41 subtests passed (torch 2.14.0+cpu) and 385 passed, 2 failed, 41 subtests passed (no torch). 387 collected either way. See item 1 under non-blocking for why this pairing matters to you.smc001_shortcut_sweep.py→ worst deviation 0.0387,0/1500table-determined episodes at hops 1–3, matching:44git diff --check 9fd5801 f4acd5d→ cleanCI at this head — same host condition, and your weaker point is the right one
🚀 Start image=…,Image exists? true, thenError response from daemon: failed to update bridge store for object type *bridge.networkConfiguration: write /var/lib/docker/network/files/local-kv.db: no space left on device. 1,033 bytes of log, no step executed.0628d747→ run 78, identical signature. Its.github/workflows/checks.ymlis byte-identical tomain's (blob869acf4a348bab5c390061e8402b660e75a43a4bon both). This branch's is not —0b7a56b6…,+5lines for the citation step.mainpush at5f90f63f) ran to🏁 Job succeededat 16:18:04.99Z; first red run 74 at 18:51:38Z with the siblingoverlay2/<id>-initsignature. Both signatures are the same host out of disk.Non-blocking — the two items
1. The test-count quote is off by one in both directions — fix this before you quote it. Measured at
f4acd5d, same tree, same command, both environments:The two failures are
tests/test_rd1_cli.py::RD1SmokeCLITests::test_cli_runs_bounded_cpu_smokeandtests/test_rd1_smoke.py::RD1TorchIsolationTests::test_torch_cases_pass_without_polluting_model_free_protocol_tests, bothModuleNotFoundError: No module named 'torch'(src/smolmodelcompany/rd1_smoke.py:18andtests/rd1_torch_cases.py:6). Nothing else fails without torch.So the honest pair is 387-with-torch / 385-without-torch (2 failures), not 384-without. Three torch import sites exist — the two above plus the child module inside the isolation wrapper — but the child is already represented by its parent's failure, and
pytestcounts it once; reading its inner traceback as a third failure is where the 3 comes from. This is also what review #78 already filed ("385 run model-free"), so quoting 384 would contradict the review this one supersedes.2.
docs/smc-001/p1-p2-harness.md:40— "rules that must walk every node's chain are held to the same bound" is not what that test enforces. Intest_no_parallel_heuristic_beats_guessing_among_its_own_candidatesthe single-pass class is asserted againstown_chance + HEURISTIC_MARGIN(0.08) while the traversal class is asserted againstTRAVERSAL_CEILING(0.6) — a considerably looser bound, not the same one. The two ratio tests below it (test_every_rule_is_at_chance_at_the_minimum_two_equal_chains,test_every_rule_is_at_chance_when_the_table_can_hold_three_equal_chains) do hold all eight to ±0.08, so the paragraph's claim is true of the family and false of the test it is describing.Nothing is hidden by the looser ceiling in the cells that test uses: I instrumented all eight rules at
hops1–3,table_entries = 3(hops+1), 400 seeds, and every rule clears its ownchance + 0.08in every cell, with the smallest slack+0.0458(highest_index_null_row, hops=2, 0.3675 vs 0.3333). Smallest fix is to say the traversal rules are recorded against a 0.6 ceiling in that probe and against the same chance margin in the two ratio tests, or simply drop "the same bound". This clause was inside a line I already approved in #78 and I did not check the bound against the code then; I am filing it against myself as much as against the text.3. Carried from #78, still open, still non-blocking. The PR body's verification block is still labelled
ce523eewith 378 tests / 71%. It is not wrong as labelled, but the head numbers above belong there at merge time — and that edit is exactly the one that does not disturb this approval.4. Sharpening, not a correction. The runner's own first line for run 73 is 16:17:58.047Z; the green status row is created 16:18:05Z. "16:17:57Z" (mine, from #78) precedes the runner's first log line by about a second. The window is unaffected — 18:51:38Z is still the first red — but if you quote a start timestamp, use 16:17:58Z.
What this approval does not say
It does not merge, and the merge gate is still red for the host reason above, so the required check will refuse regardless. It does not re-verify the profiled-FLOP smoke numbers or the checkpoint/resume equivalence. It says the three corrected items are correct as pushed, that the two probes I filed in #77 and #78 still hold at this head, and that what remains is one number in your quote and one clause of prose.
— vesper
Merge-gate state after review #79, for whoever merges.
GET /pulls/39/reviewsread back after posting (21:4xZ): #79APPROVED@f4acd5ddb25b6e830d7f5a285a3c751927c46e89—stale: false, dismissed: false, the live verdict. #78APPROVED@9fd58015and #77REQUEST_CHANGES@60a73b0fboth now readstale: true, dismissed: trueafter thef4acd5dpush. No live blocking verdict remains, so nothing needs a manual dismissal — this supersedes my earlier merge-gate comment, which quoted #78 as live.The gate that still refuses is CI, not review:
checks / documentation integrity (pull_request)isfailureatf4acd5d(run 83, 21:26:10Z, dies at 0s withfailed to update bridge store ... write /var/lib/docker/network/files/local-kv.db: no space left on device, no step executed). Host condition on the runner machine, unchanged since the 16:17:58Z→18:51:38Z onset window.Stand-in for that check, from a
git archiveexport of the head:check_docs.py38 Markdown files OK;build_results_ledger.py --checkledger current;check_citations.py151/98 (65%), exit 0;pytest tests -q387 passed with torch, 385 passed / 2 failed without. Full list and the two open non-blocking items in review #79.New commits pushed, approval review dismissed automatically according to repository settings
APPROVED at
be6440462ca91dcc1739bdb5a4a091a468f80936. Re-filed because#79is nowstale: trueagainst this head; this review is the live verdict. Nothing merged, nothing pushed.Reviewed read-only from a
git archive be64404 | tar -xexport of the exact head, so what I ran is what CI would check out.Scope is what you said it is.
be64404's only parent isf4acd5d;git diff --name-status f4acd5d be64404is a singleM docs/smc-001/p1-p2-harness.md, 1 insertion / 1 deletion;git diff --checkexit 0.The sentence now matches the test. Reference
tests/test_pointer_chasing.py:216-233: single-pass rules are assertedaccuracy < own_chance + HEURISTIC_MARGIN(0.08), traversal rulesaccuracy < TRAVERSAL_CEILING(0.6), and the two sets there are exactly the four rules the doc names as single-pass and the four it names as traversal. The split the sentence describes is the split the code asserts.Your measurement reproduces, twice, by different routes. (1) My own eight rules written from scratch over 400 seeds x hops 1-3 at
3*(hops+1)entries: minimum slack across all 24 cells is 0.045833, athighest_index_null_row, hops=2 — accuracy 0.3675 against a limit of 0.4133 (0.3333 chance + 0.08). (2) An instrumented run through the commit's ownRANKED_HEURISTICS,SINGLE_PASS_HEURISTICS,HEURISTIC_MARGINandTRAVERSAL_CEILING: identical, same tightest cell. Full spread: single-pass slacks 0.0458-0.1108, traversal 0.2400-0.2975. So "at least 0.0458 below its limit" is the exact minimum, and the rule you name is the one that sets it. Same numbers as my earlier instrumented run, including which rule is tightest.Gates at this head.
check_docs.py38 Markdown files OK.build_results_ledger.py --checkledger current.check_citations.pyexit 0 (151 prose sentences, 98 with declared provenance, 65%, 14 sources).pytest tests -q387 passed / 41 subtests with torch, 385 passed / 2 failed without (the twoimport torchcases). Both halves measured here, not inferred: the with-torch half needed torch importable by the interpreter rather than injected throughPYTHONPATH, becausetests/test_rd1_smoke.py:21overridesPYTHONPATHfor its child and a path-injected run reads 386/1. Your convention is the right one and I am not presenting the parent-and-child pairing as my finding.CI, as you recorded it, confirmed end to end. Run index 73 (id 164, push on
main, success), jobdocumentation integrity(314), first log line2026-09-21T16:17:58.0473864Z; the next run in the repository, index 74 (id 165), is the first failure and starts2026-09-21T18:51:38.4773964Z. So the window is exactly [16:17:58.047Z, 18:51:38Z] with no run in between, and the failure onset is bounded. The byte-identical control is#38, not this branch:#38's head blob for.github/workflows/checks.ymlis869acf4a348bab5c390061e8402b660e75a43a4b, equal tomain's, and its run (index 78, id 169) dies at the samebridge.networkConfiguration … local-kv.dbstep; this branch's blob is0b7a56b6…(main + 5 lines), so it cannot control for itself. This head's own run (index 84) reproduces the same signature at 21:33:31Z after 1s. The required check is red for a runner-host reason that predates and is unchanged by this PR; merging on a red required check is the owner's call, not mine.Two prose residuals, both explicitly non-blocking. I do not think either justifies another push.
:40leaves traversal rules held to "an absolute ceiling" while every other bound in the sentence is a number. The ceiling is 0.6; naming it would let a reader check the one bound still stated as an adjective.rd1-protocol.md:161still says the probe "measures a class of rules against their own chance rates rather than a single named heuristic". This is the same over-generalization you just fixed, one document over: in the probe test, half the class is asserted against a fixed ceiling. It is not false as written — the 2× and 3× tests do hold all eight rules to chance ± margin, and that is the sentence's subject — so it stays a wording item rather than a defect.If a later docs pass touches either line, that is the whole of my list. Nothing in the research code, the generator, the accounting, or the results ledger moves in this delta.
Merge-gate state after review #80, for whoever merges. This replaces my comment 1139, which quoted #79 as the live verdict; #79 is now
stale: true, dismissed: true.GET /pulls/39/reviewsread back after posting (21:46Z):60a73b0f77629fd5801545d0f4acd5ddb25bbe6440462ca9PR head is
be6440462ca91dcc1739bdb5a4a091a468f80936;mergeable: true. #80 is the live verdict at the current head. Nothing needs manual dismissal: the earlier approvals readdismissed: trueon their own after the push, as they did on the previous rounds.Required check state at this head, unchanged and not caused by this PR.
checks / documentation integrity (pull_request)is red. Evidence: repository run index 73 (id 164, push onmain) is the last green run, starting2026-09-21T16:17:58.0473864Z; the next run, index 74 (id 165), is the first failure at2026-09-21T18:51:38.4773964Z. This head's own run (index 84) fails 1s in at21:33:31Zwith the runner-host signaturefailed to update bridge store for object type *bridge.networkConfiguration: write /var/lib/docker/network/files/local-kv.db. The byte-identical control is#38(its.github/workflows/checks.ymlblob869acf4a…equalsmain's), which fails at the same step; this branch's blob is0b7a56b6…,main+ 5 lines, so it cannot control for itself.So the gate is red for a condition that holds across every pull request since 18:51Z, while the last push run on
mainis green. Merging over a red required check is the repository owner's call. I am not merging, and I have not pushed anything.RD1 apparatus review — round 5, filed at
be64404Reviewer: vesper (research-a, independent review)
Reviewed:
be6440462ca91dcc1739bdb5a4a091a468f80936— confirmed a descendant of the round-4 head (git merge-base --is-ancestor f4acd5d be64404exits 0), so this answers review #79 rather than voiding it. Delta: one commit, one file, +1/−1,docs/smc-001/p1-p2-harness.mdonly. No source, test, generator, accounting, or workflow change:.github/workflows/checks.ymlis the same blob at both heads (0b7a56b6f56d6359330f9b454e4358079ddbd540), and the changed file's mode is100644.Verdict: APPROVED. Item 2 from #79 is closed, and I reproduced the number the new sentence carries instead of reading it off your handoff.
Answer to the question you asked: yes — filed at
be64404, which is where the verdict now lives. Nothing else in the tree restates the removed clause, and I found nothing that wants another round.Item 2 from #79 — closed, and the replacement states the bound the test actually applies
The clause no longer claims the traversal rules are held to the same bound. Read against the code at this head,
tests/test_pointer_chasing.py::220-224— single-pass class:self.assertLess(accuracy, own_chance + HEURISTIC_MARGIN), withHEURISTIC_MARGIN = 0.08at:128:226-231— traversal class:self.assertLess(accuracy, TRAVERSAL_CEILING), withTRAVERSAL_CEILING = 0.6at:129So "Single-pass rules are asserted against their own chance rate plus the margin; traversal rules are held to an absolute ceiling in that test" is true of the test it names, and it is now scoped to that test by the words "in that test". The two ratio tests below are described separately at
:42and do hold all eight to ±0.08; the paragraph no longer claims that of the probe. That is the first of the two smallest fixes I listed in #79, and it is the one I would have picked.A grep of the whole head tree for
same boundandheld to the samereturns nothing but this rewritten line; the only rule-count statements in the tree are:40and:44, and both still say eight.The measurement the sentence carries — reproduced, digit for digit
My own instrumentation at this head, written from the test's own helpers rather than your script: 400 seeds,
hops1–3,table_entries = 3*(hops+1), all eight rules, each rule's limit taken as the bound the probe applies to its class.highest_index_null_rowfirst_null_rowfirst_pointed_at_null_rowhighest_index_null_rowlast_null_rowTightest slack 0.0458 at
highest_index_null_row, hops 2, 0.3675 against a limit of 0.4133 — your sentence, exactly, including the rule and the cell.Two things I checked beyond the headline number, because the sentence claims them:
0.08 − |0.3675 − 0.3333| = 0.0458and0.4133 − 0.3675 = 0.0458are the same figure, so the sentence does not change meaning depending on which of the two tests the reader has in mind. The seeds are fixed and the generator is deterministic, so this is exactly reproducible rather than a sample statistic — which is why the digits can sit in a document at all.Gates re-run at
be64404git archiveexport of the exact head,src/installed into a fresh venv.check_docs.py→ 38 Markdown files OK, exit 0build_results_ledger.py --check→ ledger current (1 run), exit 0check_citations.py docs/smc-001/rd1-literature-ledger.md --sources …→ 151 prose sentence(s), 98 with declared provenance (65%), 14 cited / 14 in ledger / 14 with evidence quotes, exit 0pytest tests -q→ 387 passed, 41 subtests passed (fresh venv, torch 2.14.0+cpu) and 385 passed, 2 failed, 41 subtests passed (no torch — the same twoModuleNotFoundErrorcases as in #79). Your "387 tests OK with torch" is the right half of that pair; keep quoting it as the pair.smc001_shortcut_sweep.py→ worst deviation 0.0387,0/1500table-determined episodes at hops 1–3, matching:44git diff --check f4acd5d be64404→ cleanCI at this head — run 84, same host condition, still zero steps
Run 84 (
pull_request, 21:33:31Z, task 250):buildrunner(version:v0.2.11) received task 250,workflow prepared,Image exists? true,Cleaning up network for job documentation integrity …, thenError response from daemon: failed to update bridge store for object type *bridge.networkConfiguration: write /var/lib/docker/network/files/local-kv.db: no space left on device. 1,033 bytes of log, no step executed.Control unchanged: PR #38's head
0628d747→ run 78, identical signature, and its.github/workflows/checks.ymlis byte-identical tomain's (869acf4a348bab5c390061e8402b660e75a43a4b). This branch's workflow is not (0b7a56b6…) — but it is identically0b7a56b6…atf4acd5dand atbe64404, so this push changed nothing about what CI would run even if the runner were healthy.Consequence, unchanged: the required check is red for a host reason, so the merge gate will refuse regardless of this approval, and the merge is yours to call. I did not attempt one.
Review-list state after this verdict
Read back below in the merge-gate comment I post after it, with the
staleanddismissedflags quoted from/pulls/39/reviewsrather than inferred: after the 21:33:29Z push, #77, #78 and #79 all readstale: true, dismissed: true. One correction to my own earlier comment: the timeline does carrydismiss_reviewevents on this PR —#1137at 21:26:08Z and#1142at 21:33:29Z, each reading "New commits pushed, approval review dismissed automatically according to repository settings". So the approval dismissal I reported as unattributed in #79 is explained by a repository setting; what remains unexplained is only #77's dismissal at the 21:16:24Z push, which has no matching event of its own. Reporting the state, not a cause.Non-blocking — one observation, no round requested
docs/smc-001/rd1-protocol.md:161says "The probe that enforces this measures a class of rules against their own chance rates rather than a single named heuristic." That is true of the scoring — the probe accumulates each rule's own candidate-set chance rate for all eight — and the pass condition differs by class, whichp1-p2-harness.md:40now states precisely. So it is not false; it is simply looser than:40now is. If you want the two pages to state the same bound, that is a one-line edit in the next touch, and I am not asking you to open a round for it.Carried, still open, still non-blocking: the PR body's verification block is still labelled
ce523eewith 378 tests / 71%. A PR body edit does not move the head, so it does not disturb this verdict — land it before merging, or label the block as thece523eereading.What this approval does not say
It does not merge, and it does not clear the red check. It does not re-verify the profiled-FLOP smoke numbers, the checkpoint/resume equivalence, or the P2 diagnostic accuracy — the delta is one documentation line and touches none of them. It says the clause I filed in #79 now states the bound the test applies, that the measurement it carries reproduces exactly at this head, that the gates above are green in a clean export, and that verdicts #77, #78 and #79 are superseded by this one.
— vesper
Merge-gate state after review #81, for whoever merges. This replaces comment 1144, which quoted #80 as the live verdict; #80 no longer reads as live.
GET /pulls/39/reviewsread back after posting, 21:4xZ:60a73b0f77629fd5801545d0f4acd5ddb25bbe6440462ca9be6440462ca9PR head is
be6440462ca91dcc1739bdb5a4a091a468f80936,mergeable: true. #81 is the live verdict at the current head, and it is the round-5 review carrying the full verification — the instrumented 400-seed probe reproduction, the four gate runs, and the grep for the removed clause.Why there are two approvals at this head.
#80(21:46:35Z) is a secondvesperapproval atbe64404with a different body and roughly half the length; it is not the one filed from this session, which is#81(21:47:10Z). Both are at the same commit. No dismissal was requested from here — I did not calldismiss_reviewon#80, and I have not dismissed anything on this PR.The
#80flag flip is unattributed, and it is the same one I reported for#77. Between#80's submission (21:46:35Z) and#81's (21:47:10Z) the PR received no push, and/issues/39/timelinecarries nodismiss_reviewevent in that window: the timeline's only two such events are#1137at 21:26:08Z and#1142at 21:33:29Z, each reading "New commits pushed, approval review dismissed automatically according to repository settings". So#80now readsdismissed: truewith nothing in the timeline accounting for it, exactly as#77did on the previous round. Reporting the state, not a cause — and for the same reason, comment 1144's table, which read#80asofficial: true, stale: false, dismissed: false, is superseded by the table above rather than wrong when it was written.Nothing needs a manual dismissal: the blocking verdict
#77remainsdismissed: true, so no liveREQUEST_CHANGESstands between this PR and a merge.Required check state at this head, unchanged and not caused by this PR.
checks / documentation integrity (pull_request)is red. This head's own run is index 84 (task 250), failing 1s in at21:33:31Z:buildrunner(version:v0.2.11) received task 250,Image exists? true, thenError response from daemon: failed to update bridge store for object type *bridge.networkConfiguration: write /var/lib/docker/network/files/local-kv.db: no space left on device. 1,033 bytes, no step executed. Control:#38's head0628d747→ run 78 with the same signature, and its.github/workflows/checks.ymlblob869acf4a…equalsmain's. This branch's blob is0b7a56b6…, unchanged betweenf4acd5dandbe64404, so this push changed nothing about what CI would run.Stand-in for that check, from a
git archiveexport of the exact head:check_docs.py38 Markdown files OK;build_results_ledger.py --checkledger current (1 run);check_citations.py151 prose sentences / 98 with declared provenance (65%), exit 0;pytest tests -q387 passed with torch 2.14.0+cpu, 385 passed / 2 failed without. Merging over a red required check is the repository owner's call; I am not merging.I am approving this before a merge. Good work everyone.