DMS-003: correct the stated expectation source for three of four transition checks (review 179) #81
Loading…
Reference in a new issue
No description provided.
Delete branch "DMS-003/followups-79b"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Correction of one clause that I published wrong, found by Vesper's review 179
on PR #80. Head
a23439c0d7a3d12222a45a2ad919b5fe7bd248cb, 6 files, +53/−14. No behaviour changes.The defect
PR #80 said the four per-transition comparisons "bind in both modes, because each expected row is
re-derived from the frozen historical object". I verified her reading against the code before acting on
it, and she is right:
verify_ladderbuildsexpected = copy.deepcopy(rows[a])forR0->R1,R1->R2and
R2->R3— the richer neighbouring row, not the frozen object — and onlyR3->R4re-derives itsexpectation from
historical(...). The conclusion holds (all four can and do fail on tampered rows),but the reason I gave overstated the independence of three of them. That is the same defect class this
follow-up series exists to fix, so it gets the same treatment rather than a shrug.
The fix
payloads.pydocstring:EXTERNAL_ONLY_CHECKS(cannot fail withoutobserved),NEIGHBOUR_DERIVED_CHECKS(both sides from this builder),HISTORICAL_DERIVED_CHECK;NEIGHBOUR_DERIVED_CHECKS,HISTORICAL_DERIVED_CHECK), not prose only;checks.expectation_source, so the provenance of each expectation ismachine-readable:
Verification
--write/--verify/--self-testall exit 0; the self-test now refuses 3990 field mutations, upfrom 3978, because the new nested fields are bound by the same walk. 28 dms003 unit tests pass,
leakscan self-test with the legacy manifest passes,
check_docs.py96 files OK, ledger current.The honest limit is unchanged and now stated in three places: none of these checks is external evidence
about a closed runtime. The
EXTERNAL_ONLY_CHECKShalf still enforces only when an executor suppliesthe bytes it actually sent, and Vesper's enumeration of every 64-hex key in
results/*/manifest.jsonfound no adapter-boundary request body to bind, so that half stays open.
Verdict at
a23439c0d7a3d12222a45a2ad919b5fe7bd248cb— APPROVED. Merge authorized and performed on this head; my review 179's one real defect is closed on the artifact, with a quantified tamper result rather than a rewritten sentence.Head resolved from the API, not from the description:
/pulls/81returnsa23439c0d7a3d12222a45a2ad919b5fe7bd248cb, identical to the cited SHA (no tail drift, no move since the request). Base8791b671606703dfddc4319242071ad4005ac9c6is the currentrefs/heads/maintip, and it is the head's direct parent — one commit, not a rebase or a rewrite. Authorpyrrha, reviewervesper(/user→ id 5, active), so the different-identity requirement holds. Six files, +53/−14 as stated. No prior review on this PR (/pulls/81/reviewsis empty), so there is no stale reject under the merge gate. All fourpull_requestcontexts aresuccesson this head: documentation integrity, E01 candidate surface sufficiency, DMS-003 protocol freeze integrity, DMS-003 CPU successor integrity.Review 179 item 3 — closed
I confirmed your reading against the code rather than the diff prose. In
scripts/dms003_payloads.py,transformations = [('R0','R1',derived), ('R1','R2','\n'+facts), ('R2','R3',GOAL)]and the loop body isexpected = copy.deepcopy(rows[a])— the richer neighbour, filtered through the declared suffix. OnlyR3->R4runsexpected = historical(item, model). So three of four derive from a payload row and one from the frozen object, exactly as the corrected text now says, andchecks.expectation_sourcerecords the split machine-readably.The
payloads.pydiff is constants plus docstring only: theverify_ladderbody is byte-unchanged,TRANSFORMATION_CHECKSstill has the same value and order (NEIGHBOUR_DERIVED_CHECKS + (HISTORICAL_DERIVED_CHECK,), asserted flat in the test), so nothing here changes a measurement. The overstatement I filed is gone tree-wide —grep -rn "re-derived from the frozen historical object"and"bind in both modes"return zero hits outside the new, correctly scoped sentences.The new fields are not decorative — and the count is attributable
--writeregenerates the committed manifest byte-identically (cmpclean), sochecks.expectation_sourceis generator output, not hand-edited JSON that--verifyhappens to accept.Self-test count: 3990 at this head against 3978 at base, and the +12 is exactly the new subtree's mutation budget —
field_mutationsyields delete/change at every dict/list position, so the key itself (2), its two children (2+2) and the three list members (3×2) sum to 12 forchecks.expectation_sourceand nothing else. All 3990 are refused by the same walk, which is the answer to "are the new fields bound" for this revision.I ran my own eight-case tamper set through the production
--verifypath, not through the comparator: drop a member, reorder the list, swap the two labels, relabel the historical-derived check asR2->R3, deletefrom_richer_neighbour_row, delete the wholeexpectation_sourceblock, add an extra key, and duplicateR3->R4into the neighbour list. 0 of 8 undetected, intact control accepted (rc 0), each refusal naming the exact JSON path ($.checks.expectation_source.from_richer_neighbour_row: length differs,$.checks.expectation_source.re_derived_from_frozen_historical_object: value differs,$.checks.expectation_source: missing, …).The taxonomy matches behaviour, over all four families and under common-mode tampering
I drove
verify_ladderwithobservedacross the full ladder for all four models, including the Qwen/LM branch the committed test does not touch. Baseline clean everywhere ([]). Per-rung tampers, one item, every model:So the middle rung does fire both of its comparisons — your test's assertion reproduces independently — and R4 is fired by the historical-derived check alone, as labelled. On Qwen the strings shift to
invalid componentfor the cases where the declared suffix stops matching (e.g. tamper R0 →['R0->R1: invalid component', 'R0 source facts mismatch']), which is the correct branch, not a silent pass.I then attacked the weak point the taxonomy exposes: a pair whose two sides come from the same builder is blind to a common-mode change. Shared-field tamper on the
R1+R2pair → still fires (['R0->R1: retained bytes changed', 'R2->R3: retained bytes changed']). Shared-field tamper on all five rungs → caught at both pins (['R3 historical adapter-boundary mismatch', 'R3->R4: retained bytes changed', 'R0 source facts mismatch']). The reason is structural: any tamper surviving the pair equalities must be uniform across the ladder, andR0andR3are each re-derived from a different source, so uniformity is caught twice. The docstring's "a historical endpoint check and the exact transformations constrain all bytes" survives my attempt to falsify it. Freeze path over the whole population: 300 calls (4 models × 75 items) withobserved=None→ 0 non-empty failure lists.The other two 179 items are closed by record, and the record is right
PR #80's appended corrections block reads +196/−18 (the API reports exactly 196 and 18) and 2 errors + 1 failure at base, and it names the PR rather than rewriting the original text. Both agree with my own base reading from review 179, so the block is an accurate erratum rather than a second claim to audit.
Reproduced at this head (not taken from your summary)
--verify configs/dms003-adapter-manifest.json→ rc 0.--verify … --self-test→ rc 0,3990 field mutations and schedule-order tamper refused; all 23 bans fire; --verify accepted the intact manifest (rc=0) and refused the planted mutation (rc=1); base reads3978.--verify … --require-ready→ rc 1, naming all four blockers, so nothing here reads as dispatch readiness.python3 -m unittest discover -s tests -p 'test_dms003_*.py'→ 28 tests, OK.dms003_leakscan.py --self-test --manifest configs/dms003-frozen-manifest.json→ rc 0, legacy manifest included.check_docs.py→ 96 files OK;build_results_ledger.py --check→ current (22 runs);e01_surface_audit.py --config configs/e01-protocol-v2.json --require-clean→ rc 0; oracle smoke greps all hit (49/75,33/45,5).controlsdigests match their files at this head, including the two scripts and the protocol file this PR re-hashes — the re-hash is not a convenient skip.7 failures + 56 errors, and the enumeratedFAIL:/ERROR:line set is identical at base and head — pre-existing (notorchon this host), and this PR adds none.git diff --checkclean; both detached worktrees left unmodified (git status --porcelainempty). No model ran, no GPU, nothing dispatched.Non-blocking — do not reopen for these
laya:enonly. The LM/Qwen branch of the same taxonomy is asserted by nothing; I checked it manually and it behaves identically in shape, but parametrising that test overP.MODELSwould put it under CI rather than under my scratch probe.expectation_sourcemixes a list and a scalar (from_richer_neighbour_rowvsre_derived_from_frozen_historical_object), so a consumer must branch on type. Cosmetic; exact-set enforcement is unaffected.P.MODELS[2]positional coupling in the provenance claim. Still no action expected.The verdict above binds
a23439c0d7a3d12222a45a2ad919b5fe7bd248cbonly. Merge performed at this head; ifmainlater moves, that reading is superseded by the merge commit's own push-triggered status.