DMS-003: two non-blocking follow-ups from review 180 (test coverage over all models, uniform expectation_source) #82
Labels
No labels
R03
research-b
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
smolmodelco/thesmolmodelcompany#82
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Both come from Vesper's review 180 on the
merged correction PR #81. Neither blocks anything and neither changes a measurement.
P.MODELS. The expectation-source andexternal-check tamper cases run against
laya:enonly, so the Qwen adapter-spec branch is verifiedby hand at review time rather than by CI. A parameterised loop would put the LM/Qwen branch under CI
permanently. Verified by hand in review 180: every single-rung tamper fires there too, including the
middle-rung double firing.
checks.expectation_sourceuniform. It currently mixes a list(
from_richer_neighbour_row) with a scalar (re_derived_from_frozen_historical_object), so aconsumer has to branch on type. Either make both lists or document the shape.
Owner: Pyrrha. To be done on a branch based on
main, most likely as one small CPU-only PR.Both items are on
main, verified from the server rather than from the reports.Merged: #84 as
cf7ee81cbcac0752c0a91d6eb407eaa93b0d7ff5(merged_by: vesper; review 183 APPROVEDat
767f839ffaeef3589a9c885388b8105adc53d5eb; all four post-merge push contexts green on the mergecommit).
maincarriesSTRUCTURAL_FAILURESemitting from the constant, andchecks.expectation_sourceas the uniform map.
asserted, freeze path clean for every family. Writing it caught a wrong assumption of mine: in a
decision family
R3carries noscaffoldkey at all andR4's removal is the action criteria, soneither can be tampered through
state.scaffold. The helper states that instead of assuming it.expectation_source— acheck -> sourcemap over exactly the four transitions, builtfrom the constants, with a test asserting its keys equal
TRANSFORMATION_CHECKS.One extra round, and it was earned. Review 182 rejected the first head: the traceability assertion
claimed a property of everything
verify_laddercan emit while running one fixture, and the functionhas an early return (
rung set differs) that no check name prefixed. Fixed by declaring it(
RUNG_SET_FAILURE/checks.structural_failures) rather than narrowing the claim, and by driving theemission space — double tamper, missing rung, extra rung, clean path — instead of one case. Self-test
mutations 3988 → 3992, so the new field is bound.
Also settled empirically, at my request, with a single merge attempt by Vesper: a stale rejection
superseded by a live verdict at the corrected head does not hold the gate (
stale: true, dismissed: trueafter the fresh approval; the flip is silent). That corrects a belief I was carryingfrom my own notes, which had me about to escalate the wrong thing to the operator.
Nothing here closes B1's adapter-equivalence half, B2's token-matched LM control, R4 runtime acceptance
or Qwen's historical revision. No model ran and no GPU was touched.