starsetbyte/peregrine

Watch

Fork 0

docs: record July 11 adversarial delta review #96

Closed

starsetbyte wants to merge 2 commits from docs/2026-07-11-adversarial-delta-review into main

starsetbyte commented

2026-07-12 03:34:59 +00:00

Owner

Summary

Records the adversarial current-main review performed alongside PR #95 and updates the consolidated roadmap with the resulting release gates.

6 verified P1 release risks
6 P2 correctness/quality findings
no new P0
evidence and exact source locations
revised ordering that places OAuth/DID, interaction-state, startup, and backup boundaries before DM Phase A

Verification

Executed on main at 2d227be before writing the report:

./gradlew testDebugUnitTest lintDebug --rerun-tasks --no-daemon
BUILD SUCCESSFUL
653 tests, 0 failures, 0 errors, 2 skipped
lint: 0 errors, 135 warnings

The review distinguishes verified defects from runtime consequences that still require device/integration characterization.

## Summary Records the adversarial current-main review performed alongside PR #95 and updates the consolidated roadmap with the resulting release gates. - 6 verified P1 release risks - 6 P2 correctness/quality findings - no new P0 - evidence and exact source locations - revised ordering that places OAuth/DID, interaction-state, startup, and backup boundaries before DM Phase A ## Verification Executed on `main` at `2d227be` before writing the report: ```text ./gradlew testDebugUnitTest lintDebug --rerun-tasks --no-daemon BUILD SUCCESSFUL 653 tests, 0 failures, 0 errors, 2 skipped lint: 0 errors, 135 warnings ``` The review distinguishes verified defects from runtime consequences that still require device/integration characterization.

starsetbyte added 1 commit

2026-07-12 03:34:59 +00:00

docs: record adversarial delta review

carin/review Carin review in progress...

Details

carin/pr-review Carin PR review in progress...

Details

peregrine-ci / assembleDebug Build succeeded (5s)

Details

Peregrine CI / Build & Test (JDK 17) (pull_request) Successful in 4m58s

Details

Peregrine CI / Signed Minified Release Build (pull_request) Successful in 4m10s

Details

Peregrine CI / Instrumented Tests (API 29+) (pull_request) Has been skipped

Details

6bbdf11eff

starsetbyte referenced this pull request

2026-07-13 01:30:20 +00:00

fix: notification accessibility, locale-aware timestamps, release checklist (P2-5, P2-6) #100

starsetbyte commented

2026-07-13 01:30:21 +00:00

Author

Owner

Integration note

PR #100 independently adds the same docs/reviews/2026-07-11-adversarial-delta-review.md path with different content. A synthetic merge of #96 then #100 produces an add/add conflict. Please establish one canonical owner for this document and have the other PR rebase/drop its duplicate before merge.

Minor hygiene: this Markdown addition currently has three trailing-whitespace lines under git diff --check.

## Integration note PR #100 independently adds the same `docs/reviews/2026-07-11-adversarial-delta-review.md` path with different content. A synthetic merge of #96 then #100 produces an add/add conflict. Please establish one canonical owner for this document and have the other PR rebase/drop its duplicate before merge. Minor hygiene: this Markdown addition currently has three trailing-whitespace lines under `git diff --check`.

starsetbyte added 1 commit

2026-07-13 01:56:22 +00:00

docs: remove review markdown trailing whitespace

peregrine-ci / assembleDebug Build succeeded (6s)

Details

Peregrine CI / Build & Test (JDK 17) (pull_request) Successful in 4m23s

Details

Peregrine CI / Signed Minified Release Build (pull_request) Failing after 2m59s

Details

Peregrine CI / Instrumented Tests (API 29+) (pull_request) Has been skipped

Details

848844baea

starsetbyte commented

2026-07-26 03:22:33 +00:00

Author

Owner

main's copy of docs/reviews/2026-07-11-adversarial-delta-review.md is strictly more complete than this branch's: its release checklist is ticked with per-finding branch and commit citations plus an "Accepted deviations" section, where this branch carries the pre-remediation unticked version. One hunk here is unrelated to the checklist — 848844b strips trailing whitespace from three header lines, which on main are markdown hard breaks. Nothing substantive is lost. Branch deleted.

Reconciled in docs/reviews/2026-07-25-branch-pr-reconciliation.md, which landed on main via #103.

`main`'s copy of `docs/reviews/2026-07-11-adversarial-delta-review.md` is strictly more complete than this branch's: its release checklist is ticked with per-finding branch and commit citations plus an "Accepted deviations" section, where this branch carries the pre-remediation unticked version. One hunk here is unrelated to the checklist — `848844b` strips trailing whitespace from three header lines, which on `main` are markdown hard breaks. Nothing substantive is lost. Branch deleted. Reconciled in `docs/reviews/2026-07-25-branch-pr-reconciliation.md`, which landed on `main` via #103.

starsetbyte closed this pull request

2026-07-26 03:22:33 +00:00