test: final closed review loop v2 #6

Closed

starsetbyte wants to merge 3 commits from test/review-loop-v2 into main

pull from: test/review-loop-v2

merge into: starsetbyte:main

starsetbyte:main

starsetbyte:test/pr-e2e

starsetbyte:test/ship-it

starsetbyte:test/v6

starsetbyte:test/v5

starsetbyte:test/e2e-v4

starsetbyte:test/e2e-final

starsetbyte:test/review-loop-final

starsetbyte:test/pr-pipeline-live

starsetbyte:codex/agentic-web-interface-plan

starsetbyte:autonomous-iterative-loop

Conversation 5 Commits 3 Files changed 7 +1124 -12

starsetbyte commented 2026-07-12 03:33:43 +00:00

Owner

Copy link

Final test with all fixes: isGitHub detection, forge metadata forwarding, GitHub→Forgejo fallback.

Final test with all fixes: isGitHub detection, forge metadata forwarding, GitHub→Forgejo fallback.

starsetbyte added 5 commits 2026-07-12 03:33:43 +00:00

test: PR webhook E2E pipeline test 84de947039

feat: PR webhook pipeline, per-run model overrides, dashboard redesign, max_retries fix ... c6c43f7b4b

Webhook (internal/webhook/inbound.go):
- Handle pull_request events (opened/synchronize/reopened)
- Parse Forgejo/GitHub PR payloads into normalized preEvent
- Post pending commit status on Forgejo for PR head SHA
- HMAC verification for both X-Hub-Signature-256 and X-Forgejo-Signature
- Idempotency via delivery ID (returns 409 on duplicate)
- 5 new PR-specific tests + 8 existing push tests

Model overrides (model/run.go, store, api, dispatch):
- Run.ProviderOverride, Run.ModelOverride fields
- Wired through CreateRun/UpdateRun/scanRun/params()
- spawnExternal: override persona defaults when run has overrides set
- Schema: provider_override + model_override columns

Max retries fix (store/runs.go):
- CreateRun INSERT now uses p.MaxRetries instead of hardcoded 0
- UpdateRun SET includes max_retries
- API runRequest.params() maps MaxRetries

Dashboard redesign (Overview.svelte):
- Replace kanban with health bar + agent grid + run table
- Compact flight-instrument design: status dots, tabular-nums
- Run table and agent health table with status colors
- Expandable create-run form with model/provider overrides
- Fix <tr> without <tbody> SSR warnings, remove empty CSS

fix: close the review loop — commit status + PR comments ... 856bfde62e

Bug fix: parseForgejoCommitMeta used SplitN(rest, '|', 3) which
concatenated SHA|DIFF_URL for PR webhook runs (4 pipe-delimited
fields), causing Forgejo to reject the malformed SHA. Commit status
updates silently failed, leaving PRs stuck at 'pending' forever.

Fix: SplitN(rest, '|', 4) handles both push (3 fields) and PR (4
fields). Same fix applied to parseGitHubCommitMeta.

Optimization: extractPRNumber() parses [PR #N] from run titles,
skipping the GetCommitPRs API call for PR webhook runs. Push
webhook runs fall back to GetCommitPRs as before.

Context matching: postForgejoCommitStatus now uses carin/pr-review
for PR runs (matching the inbound webhook handler) instead of
hardcoded carin/review.

Tests: 7 new tests covering push/PR/no-match parsing for both
Forgejo and GitHub, plus extractPRNumber edge cases.

All 12 test packages pass, vet clean.

test: trigger closed review loop d986561ed4

test: final closed loop verification 89ec8026f7

starsetbyte commented 2026-07-12 04:00:25 +00:00

Author

Owner

Copy link

🔍 Carin Code Review

Run #234 completed by pi-dispatcher

---

95817593e65ab5b9a8b3c37a56f4a765

---

Posted by Carin • View run

## 🔍 Carin Code Review *Run [#234](http://astraea1:8787/ui/runs/234) completed by `pi-dispatcher`* --- 95817593e65ab5b9a8b3c37a56f4a765 --- *Posted by [Carin](http://astraea1:8787/ui/runs/234) • [View run](http://astraea1:8787/ui/runs/234)*

starsetbyte commented 2026-07-12 04:01:35 +00:00

Author

Owner

Copy link

🔍 Carin Code Review

Run #234 completed by pi-dispatcher

---

Dispatch Decision — PR #6 Review

Task

Review PR #6 in starsetbyte/Carin (test/review-loop-v2 → main).
Author: starsetbyte. Commit: 89ec8026.

"Final test with all fixes: isGitHub detection, forge metadata forwarding, GitHub→Forgejo fallback."

Routing decision

Single persona: pi-reviewer (deepseek-v4-pro) → spawned as run #236 (mode: review, thread #405).

Why pi-reviewer

This is a pure code-review task against an existing PR diff. Per routing rule #3 (reviewing existing changes → pi-reviewer). The PR touches a single coherent area (forge/git-platform detection + metadata forwarding), so a single reviewer run is appropriate — no architect/builder chain needed since no new code is being written.

Why not other personas

• pi-architect — not needed; no plan is being requested, only a review.
• pi-builder — not needed; no implementation work.
• pi-researcher — not needed; the scope is a self-contained diff, not an ecosystem scan.
• pi-thinker — reserved in case the reviewer uncovers a subtle logic bug that needs escalation; not the first hop.

Handed off to reviewer

The reviewer has been instructed to:

1. Fetch the diff from https://durandal.exe.xyz/starsetbyte/Carin/pulls/6.diff.
2. Check correctness of isGitHub detection, forge metadata forwarding, and the GitHub→Forgejo fallback.
3. Run go build ./..., go vet ./..., go test ./... against the branch if checkable.
4. Produce a review.md artifact with line-referenced feedback.
5. Emit a VERDICT: approve or VERDICT: revise line in its completion summary.

State

• Run #236 status: queued (awaiting the built-in dispatcher to spawn pi-reviewer).
• Thread: #405.

---

Posted by Carin • View run

## 🔍 Carin Code Review *Run [#234](http://astraea1:8787/ui/runs/234) completed by `pi-dispatcher`* --- # Dispatch Decision — PR #6 Review ## Task Review PR #6 in starsetbyte/Carin (`test/review-loop-v2` → `main`). Author: starsetbyte. Commit: `89ec8026`. > "Final test with all fixes: isGitHub detection, forge metadata forwarding, GitHub→Forgejo fallback." ## Routing decision **Single persona: `pi-reviewer`** (deepseek-v4-pro) → spawned as **run #236** (mode: review, thread #405). ### Why pi-reviewer This is a pure code-review task against an existing PR diff. Per routing rule #3 (reviewing existing changes → pi-reviewer). The PR touches a single coherent area (forge/git-platform detection + metadata forwarding), so a single reviewer run is appropriate — no architect/builder chain needed since no new code is being written. ### Why not other personas - **pi-architect** — not needed; no plan is being requested, only a review. - **pi-builder** — not needed; no implementation work. - **pi-researcher** — not needed; the scope is a self-contained diff, not an ecosystem scan. - **pi-thinker** — reserved in case the reviewer uncovers a subtle logic bug that needs escalation; not the first hop. ## Handed off to reviewer The reviewer has been instructed to: 1. Fetch the diff from `https://durandal.exe.xyz/starsetbyte/Carin/pulls/6.diff`. 2. Check correctness of `isGitHub` detection, forge metadata forwarding, and the GitHub→Forgejo fallback. 3. Run `go build ./...`, `go vet ./...`, `go test ./...` against the branch if checkable. 4. Produce a `review.md` artifact with line-referenced feedback. 5. Emit a `VERDICT: approve` or `VERDICT: revise` line in its completion summary. ## State - Run #236 status: **queued** (awaiting the built-in dispatcher to spawn pi-reviewer). - Thread: #405. --- *Posted by [Carin](http://astraea1:8787/ui/runs/234) • [View run](http://astraea1:8787/ui/runs/234)*

starsetbyte commented 2026-07-12 04:16:04 +00:00

Author

Owner

Copy link

🔍 Carin Code Review

Run #234 completed by pi-dispatcher

---

95817593e65ab5b9a8b3c37a56f4a765

---

Posted by Carin • View run

## 🔍 Carin Code Review *Run [#234](http://astraea1:8787/ui/runs/234) completed by `pi-dispatcher`* --- 95817593e65ab5b9a8b3c37a56f4a765 --- *Posted by [Carin](http://astraea1:8787/ui/runs/234) • [View run](http://astraea1:8787/ui/runs/234)*

starsetbyte commented 2026-07-12 04:51:48 +00:00

Author

Owner

Copy link

🔍 Carin Code Review

Run #234 completed by pi-dispatcher

---

95817593e65ab5b9a8b3c37a56f4a765

---

Posted by Carin • View run

## 🔍 Carin Code Review *Run [#234](http://astraea1:8787/ui/runs/234) completed by `pi-dispatcher`* --- 95817593e65ab5b9a8b3c37a56f4a765 --- *Posted by [Carin](http://astraea1:8787/ui/runs/234) • [View run](http://astraea1:8787/ui/runs/234)*

starsetbyte commented 2026-07-12 04:53:19 +00:00

Author

Owner

Copy link

🔍 Carin Code Review

Run #234 completed by pi-dispatcher

---

95817593e65ab5b9a8b3c37a56f4a765

---

Posted by Carin • View run

## 🔍 Carin Code Review *Run [#234](http://astraea1:8787/ui/runs/234) completed by `pi-dispatcher`* --- 95817593e65ab5b9a8b3c37a56f4a765 --- *Posted by [Carin](http://astraea1:8787/ui/runs/234) • [View run](http://astraea1:8787/ui/runs/234)*

starsetbyte closed this pull request 2026-07-12 16:14:53 +00:00

Some checks are pending

Hide checks

carin/review Carin review in progress...

Details

carin/pr-review Carin review passed

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

starsetbyte/Carin!6

No description provided.