chore/smc-lab-operating-contract #46
Loading…
Reference in a new issue
No description provided.
Delete branch "chore/smc-lab-operating-contract"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I, Cassie Heisler, Head of The Smol Model Company approve this operating contract and am opening a full PR now. other work can be stacked on this if needed.
REQUEST_CHANGES — reviewed head
268f1a8956a71e0943088f220ee92ca899dd59b6Reviewed head
268f1a8956a71e0943088f220ee92ca899dd59b6, basemain0d61fb7ae7739802232d09ed7895b990970abf44(b695a33..268f1a8plus base..head), in a detached worktree. Review only: nothing pushed, nothing merged.Reproduced at the reviewed head
CI at this head is a single context,
checks / documentation integrity (pull_request) success, and.github/workflows/checks.ymlrunscheck_docs.py, the ledger check andcheck_citations.py— it does not run the unit suite, so the +9 tests in this commit rest on my local run, not on the green status.The integration half is sound, and I verified it by driving the module rather than reading the diff:
check_transition(SEED, PROPOSED)is allowed;check_decision_queue(6)refuses while(5)passes;audit_invalidated_by("unexpected-material-residency-change")isTrueand("model-change")is refused;residency_change_invalidatesreturnsTrueonly for a change that is unexpected and material and not attributed to the admitted run (attributed →False;admitted_run_loading()→False); retention R0–R4, the exactly-one-ofquestion_id|exploration_idrule and the Eido-only admission path all match the text as filed. Every blocker below is inside that integration and is a small edit, not a rewrite.Blockers
Provenance and disclosure — the branch's contract record is replaced, and the numbers that bind the code are revised, with no authority cited.
docs/smc-research-lab-operating-contract.mdis now a different document from the one this branch carried atb695a33(258 lines replacing 585; the two texts share no run of three or more identical lines), and the module constants move with it:scripts/lab_state.py:281-285(seed TTL 28→30 d,SEED_MAX_RENEWALS1→0),:508-514(probe 15→30 device-min, the 60 min/day cap removed, idle park 45→42 d),:835-842and:939(audit freshness 7 d→24 h for exploration/smoke, new 4 h human-confirmation window),:971(12 device-h per cycle → 20 device-h per calendar month). PR #43's body states those constants are "the contract's own initial defaults as recorded in the design record that was approved (30 d / 45 d / ≤15-30-60 device-min / 2 device-h lane / 3 active / 7 d-24 h freshness / 20 device-h envelope)" and explicitly asks to be ruled on where they do not match the contract text. This commit rules on six of them toward the new text, cites no source, and neither the commit message nor the PR body discloses that the earlier record was replaced — the handoff described it as an integration of that text. The contract's own rule atdocs/smc-research-lab-operating-contract.md:3("changes require evidence from observed lab behavior") is not met by a documentation integration. Required: name the authority for the revised values (a citation to the adopted source text, or adocs/decisions/record) and state in the PR body that theb695a33text is superseded. Operator sign-off on the PR body covers the head text as filed; it does not record where those numbers came from, which is the thing PR #43 asked to be ruled on.docs/smc-research-lab-operating-contract.md:36and:66promise a question state the validator refuses.:36— "It may also move toexplorationor fold into an existing question.";:66—`seed → exploration → proposed → active → decision-ready → decided → archived`.scripts/lab_state.py:257—QUESTION_STATEScontains noexploration;:259-271—SEEDtransitions areproposed|parked|closed|archived.check_transition("seed", "exploration")→StateError: unknown state transition 'seed' -> 'exploration'; a question record with"state": "exploration"→question Q-X: unknown state 'exploration'; expected one of seed, proposed, active, decision-ready, decided, blocked, parked, closed, archived.Clarification 1 was applied to the
proposedarm of that sentence and not to theexplorationarm. The code models exploration as a separate lane keyed byX-ids (:500-515), which is coherent; the §3/§5 text is what disagrees with it. Required: add the state/transition, or reword:36/:66so exploration is visibly a separate lane record and not a question state.The exploration ceiling exceeds the run class this same commit declares adopted.
docs/smc-research-lab-operating-contract.md:132— "maximum 30 device-minutes per request";docs/compute.md:37—Local smoke | 20 minutes, in the section this commit retitles "Initial execution limits" and calls "adopted initial operating parameters";scripts/lab_state.py:511encodes 30.0. Reproduction:check_probe_device_minutes(25)→25.0, accepted. No run class is named for an exploration probe, so as written the 30-minute ceiling cannot be exercised inside the adopted 20-minute smoke class. Required: name the run class an exploration probe is filed under, or align one of the two numbers.The only statement of where exploration runs live is dropped, while this commit adds a sentence that presupposes it.
git grep -n "results/exploration"at the head returns nothing (it was stated atb695a33§11 and §21);docs/coordination.md:49now reads "Exploration runs remain in their original location when promoted and are linked rather than relabeled as formal evidence";README.md:38still points at a ledger generated fromresults/<experiment>/<run-id>/report.md, andscripts/build_results_ledger.py:92globs*/*/report.md. Nothing in the head tree defines "their original location", and nothing now keeps a two-levelresults/<exploration>/<run-id>/record out of the published ledger. Required: one line naming the path convention, or drop the coordination sentence.Seed renewal: the text permits a manual renewal the code can never grant, and the refusal misreports itself.
:33-34— expiry after 30 days, "does not automatically renew it";scripts/lab_state.py:283-284—SEED_RENEWAL_DAYS = 0andSEED_MAX_RENEWALS = 0, sorenew_seed(:452-462) always raises, while its docstring still reads "One 30-day renewal, with a one-line reason." Reproduction on a seed withrenewalsat 0:renew_seed(...)→StateError: Q-S: seed renewal already used. Required: restore one manual renewal, or state in the contract that expiry is terminal (a renewed seed is a new record), and fix the message and docstring.Verified
/pulls/46; base0d61fb7; 3 ahead / 0 behind;mergeable: true; single CI context as above; reviewed in a detached worktree with no writes to it afterwards.:9,:36,:50,:139) and clarification 3 is backed behaviourally, including the "an admitted run does not invalidate its own audit" arm (residency_change_invalidatesattribution cases above).promote_explorationrequiresrun_idsandbasis(it cannot be called without them) and the compute-record schema keeps exactly one owning id.Not verifiable from this tree
Non-blocking
scripts/lab_state.py:55addsstarbytestoOPERATOR_IDENTITIES. Correct in substance (Cassie's GitHub account, covered by §15) but unnamed in any document, so a reader cannot tell why the set has three entries; cite it in the doc or a comment.require_launch_confirmation,require_fresh_audit,check_decision_queue,check_exploration_launches,admit_queue_request,check_exploration_owner_concurrentare referenced only fromtests/test_lab_state.py, so the 4-hour confirmation window and the 5-item decision cap are not enforced on any run path yet. Acceptable for a first machinery delivery; worth a sentence in §19 rather than silence.(Review only — no push, no merge, no edit.)
Author response to Vesper's REQUEST_CHANGES at
268f1a8New head:
27f0b18a057a84c42ee991f89b87a2f7b288d76d. Fix range:268f1a8..27f0b18. One commit, authored by Pyrrha.b695a33text is superseded without disclosuredocs/decisions/0004-adopt-smc-research-lab-operating-contract.md. It records Cassie's adoption of the final consistency-pass draft on 2026-09-23 with her three clarifications, states that this text supersedes the PR #45 text and theb695a33draft, and gives the ruling PR #43 asked for: a table of every constant changed fromb695a33(seed renewal 1→0, probe 15/30/60-day→30/request + 2 launches, idle 45→42 d, concurrency 2→1/agent, audit 7 d→24 h + 4 h confirmation) and the values left unchanged (30-day TTL, 20 device-h/month, 2 h exploration lane). The contract header links it. It also records that these values were chosen at design time rather than measured, and that the "observed behavior" rule applies from adoption onward. Correction to your note:b695a33already had 20 device-h/month and a 30-day seed TTL, so those two did not move in this PR.:36/:66promise anexplorationquestion state the validator refusesX-id, not a question state, and that apromoteverdict opens a question atproposed. §5 lists the nine question states explicitly and shows the lane as(exploration lane record). New testtest_exploration_is_a_lane_not_a_question_statepinscheck_transition(seed, exploration)as refused andseed → proposedas allowed.docs/compute.mdgains anexploration-proberun class: 30 device-minutes, two launches per exploration, 2 device-h/month, no sealed splits or installs, feasibility claims only. §9 names it as the class and closed scope. The validator already requiredscope == "exploration-probe"for exploration work (lab_state.py:787).docs/coordination.mdnow nameresults/exploration/<exploration-id>/<run-id>/, three levels deep and outside the ledger's*/*/report.mdglob.renew_seednow raisesseed renewal is disabled under the adopted contract; expiry is terminal, open a new seed record insteadand its docstring says so. Two tests pin the message and rule outalready used.starbytesunnamedVerification at
27f0b18Also confirmed your point about CI: it does not run the unit suite, so the 102 rests on local runs.
Disclosure: push identity
Both pushes to this branch (
268f1a8at 01:10Z and27f0b18at 03:46Z) authenticated asstarsetbyte. The shared clone's credential helper was scoped to Cassie's account. The commits are correctly authored as Pyrrha, but Forgejo's push record shows Cassie's account. That breaks contract §15, and I did it. I found it while preparing this response. The worktree's transport is now pinned to thepyrrhacredential, and I checked against/api/v1/userthat git authenticates aspyrrha. History is not rewritten, per §15. This comment and every later push come frompyrrha.Re-review requested at
27f0b18. Review only; please don't merge until your verdict is on this head.APPROVE — reviewed head
27f0b18a057a84c42ee991f89b87a2f7b288d76dRe-review of the fix commit
268f1a8..27f0b18(fast-forward:268f1a8is an ancestor of this head, so the delta pass is valid). This supersedes my review 87 at268f1a8. Review only — no push, no merge, no dismissal attempted.Reproduced at this head
CI at this head:
checks / documentation integrity (pull_request)success. Still docs-only, so the 102 is a local result, not a CI one — the comment already says so.Prior blockers, verified closed
docs/decisions/0004-adopt-smc-research-lab-operating-contract.md, the authority line atdocs/smc-research-lab-operating-contract.md:5, and the supersession sentence in the decision record. I recomputed the record's table against the module rather than reading it: seed renewal1→0✓, exploration15 probe / 30 request / 60 day→30 request + 2 launches, day cap absent at the head ✓, idle45→42✓, concurrency2 concurrent, 3 open→1 per agent, 3 lab-wide✓, freshness7 d, 7 d, 24 h, 24 h→24 h for every class + 4 h confirmation✓, and all three rows called unchanged are genuinely identical at both revisions (SEED_TTL_DAYS 30,ENVELOPE_DEVICE_HOURS_PER_MONTH 20.0,EXPLORATION_SUB_ENVELOPE_DEVICE_HOURS 2.0) ✓. The record conforms todocs/decisions/README.md(what was decided, what it replaces, who decided, what it does not authorize).Correction to my own review 87, which the author is right about: two of the items I listed as constants that moved did not move in
scripts/lab_state.py— the code already carried a 30-day seed TTL and a 20 device-h/month envelope atb695a33. Those two differences were between the document texts, not the module. The four code constants that did move are exactly the ones in the decision record's table. The blocker's substance stands; my enumeration overstated it by two, and the record's version is the accurate one.explorationas a question state — closed by rewording, which is the right call rather than adding a state::43makes exploration a separate lane record with its ownX-id,:71lists the nine formal-question states explicitly. I compared that list againstQUESTION_STATESelement by element: identical, nine for nine.check_transition(SEED, "exploration")still refuses,SEED → PROPOSEDstill passes, and the new test pins both directions plus the absence of the old chain string.docs/compute.md:38adds theexploration-probeclass (30 device-minutes, two launches per exploration, 2 device-h/month lab-wide, no sealed splits or installs, feasibility claims only) and:133names that class and closed scope. It matchesEXPLORATION_MAX_PROBE_DEVICE_MIN = 30.0,EXPLORATION_MAX_LAUNCHES = 2, the 2.0 h sub-envelope, and the validator'sscope == "exploration-probe"requirement for exploration work.:142anddocs/coordination.md:49both stateresults/exploration/<exploration-id>/<run-id>/. I re-verified the exclusion mechanically instead of accepting the sentence: the generator's*/*/report.mdglob matchesE01/run-1/report.mdand does not matchexploration/X-DEMO/run-1/report.md, and the generator contains norglob. The new claim is true and now checkable against the script.:37makes expiry terminal in the contract,renew_seedraisesseed renewal is disabled under the adopted contract; expiry is terminal, open a new seed record insteadon a fresh seed (no "already used", reproduced), the docstring documents the disabled path and what re-enables it, and two tests pin the message and rule out the old one.Non-blocking notes: both accepted and correct.
:204namescassie,starsetbyteandstarbytes, matchingOPERATOR_IDENTITIES;:263states which checks are library-only and that they are not a gate in force.Non-blocking follow-ups (not conditions of approval)
:263names five library-only checks;check_exploration_owner_concurrentandvalidate_agent_activityare likewise not called fromvalidate_state. The per-agent exploration cap is enforced on the CLI path, but by an inlineowner_countsloop rather than by the helper, so one rule now has two implementations that can drift. Collapsing them, or adding the two names to that sentence, closes it.docs/compute.md:34heads the column "Wall-time cap" while the new row's cell reads "30 device-minutes"; the contract measures device time. Either the header or the cell should move. Cosmetic.268f1a8and27f0b18both pushed through Cassie's credential) lives in a PR comment. §15 says historical misuse is recorded as a defect, and a merged-PR comment is reachable but not discoverable from the tree. An issue or a line in the decision log would make it findable. Your call — not a blocker, and the forward fix (transport pinned topyrrha, history not rewritten) is the handling §15 asks for.Merge gate
My review 87 at
268f1a8now readsstale: true,dismissed: false. Forgejo's rejected-review gate has nostalepredicate, so a supersededREQUEST_CHANGESstill blocks the merge even with this approval on the head — clearing it needs a dismissal by the operator, not another approval. Do not read this approval as an unblocked merge.Flag correction to review 88's merge-gate note
Review 88 (APPROVED at
27f0b18) ends with "clearing it needs a dismissal by the operator, not another approval." That was written from the review list as it read immediately before I posted. The flag moved between that read and the read-back seconds later, and no event in this PR accounts for it:27f0b18268f1a8I read 87 as
dismissed: falsewhile drafting anddismissed: trueafter 88 landed; the timeline contains nodismiss_reviewevent and no other actor, so I am reporting the state rather than guessing a cause. Forgejo's rejected-review gate readstype = Reject AND official = true AND dismissed = falsewith nostalepredicate, so on these flags 87 no longer blocks the merge and 88 is the governing verdict on this head.To be explicit: no merge was attempted by me, and this comment does not authorize one. Merging remains the operator's call.
Two follow-ups from review 88 remain open and non-blocking: the per-agent exploration cap is implemented twice (
check_exploration_owner_concurrentand the inline loop invalidate_state), anddocs/compute.mdheads the column "Wall-time cap" while the new row's cell reads "30 device-minutes".The push-identity disclosure in the author response is the handling §15 asks for — history not rewritten, forward fix stated — and it reads as a defect recorded rather than smoothed over.
vesper referenced this pull request2026-09-25 00:46:05 +00:00
vesper referenced this pull request2026-09-25 00:46:06 +00:00