Build: OAuth redirect scheme manifest placeholder mismatch #38
Labels
No labels
auth
bug
composer
correctness
database
durability
enhancement
feeds
interactions
notifications
performance
reliability
safety
security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
starsetbyte/peregrine#38
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
app/build.gradle.ktsline 22 setmanifestPlaceholders["appAuthRedirectScheme"] = "com.peregrine.android"butAndroidManifest.xmlline 37 hardcodesandroid:scheme="com.ffxxi"directly (not using the placeholder). The placeholder value was stale — leftover from before theffxxi.comdomain was chosen for client metadata hosting.Impact
None at runtime — the manifest does not use the placeholder. But it is misleading during development and could cause a bug if someone later tries to use the placeholder in the manifest.
Fix
Updated placeholder to
"com.ffxxi"to match the actual scheme.Fixed in current working tree.