fix(E01): name the v2 protocol in the execution plan's regeneration note #67
Loading…
Reference in a new issue
No description provided.
Delete branch "E01/plan-regeneration-note"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fix(E01): name the v2 protocol in the execution plan's regeneration note
One string, one line, in
configs/e01-execution-plan.jsonnote 1. Origin: incidental item 1 of the instrument review on issue #59 (comment 1537).The defect
The note names
configs/e01-protocol.json, which is the preserved v1 protocol, as the source the frozen artifacts regenerate from. The generator refuses that config outright:Only
configs/e01-protocol-v2.jsonreproduces the hashes the note itself calls binding. Re-run in this session on the frozen tree at19474c8, with the project interpreter (~/ml/tools/smolmodelco/venv-r02/bin/python), output to a scratch directory:episode-manifest.jsonl7ac29c4de0d78524d2c7241c4e3ba89f6577a29aba305ca7a84af27034d653217ac29c4d…reference-answers.jsonl42e99c25d6a9bfab4ac4437847e315a3807c76f7b67fd68785a23b1d8352f97f42e99c25…episode-metadata.jsonl1fbc089aae9872e4bf1bd4d2cf20a881991b501310c347152d089f28c5631a8e1fbc089a…The frozen tree's working directory was untouched by that run (
git status --shortempty afterwards), and nothing was written underresults/.Deliberately not changed — disagree if either is wrong
regression_fixtures.e01-records-v1.protocol_pathstaysconfigs/e01-protocol.json: that fixture is the v1 protocol, and note 10 pins it as byte-unchanged. Pointing it at v2 would delete the regression fixture.configs/e01-protocol.json" is left as written. It describes the binding mechanism, whose default--protocolis stillconfigs/e01-protocol.jsoninscripts/e01_score.py; the amendment that made it binding is dated at the v1-to-v2 revision. If the protocol owner reads that as stale too, say so and I will widen the change — but it is not the regeneration claim this PR repairs.What this does not do
No model, no GPU, no dataset, no prediction and no run directory is touched; no run is authorized by this commit. The protocol, generator, prompt renderer, scorer, split, decoding, scoring block, runner rule and all three frozen digests are unchanged, and the plan still parses with the same 19 notes. Claim tier, the E01 stop at ≤3B, and the Q-E01c discriminator reading on #59 (comment 1548) are all unaffected — this is a provenance note about which config reproduces the frozen hashes, which is now what the plan says.
Checks
CI jobs run locally on the patched tree before pushing:
scripts/check_docs.py— 64 Markdown files OK (links, final newlines, placeholders, tabs), exit 0scripts/build_results_ledger.py --check— exit 0scripts/check_citations.py docs/smc-001/rd1-literature-ledger.md --sources …— exit 0scripts/e01_surface_audit.py --config configs/e01-protocol-v2.json --require-clean—flagged 0 (development 0, final 0), exit 0The forge's own CI on the PR head is the record; the lines above are what I ran, not a substitute for it.
— eido (compute)
The plan's note 1 told a reader that the episode and reference files are regenerated by scripts/e01_records.py from configs/e01-protocol.json. That is the preserved v1 protocol, and the generator refuses it: ValueError: configs/e01-protocol.json: declared generator revision 'records-v1' does not match 'records-v2' Only configs/e01-protocol-v2.json reproduces the hashes that same note calls binding. Verified on the frozen tree at19474c8with the project interpreter: regenerating under configs/e01-protocol-v2.json reproduces episode-manifest.jsonl 7ac29c4de0d78524d2c7241c4e3ba89f6577a29aba305ca7a84af27034d65321, reference-answers.jsonl 42e99c25d6a9bfab4ac4437847e315a3807c76f7b67fd68785a23b1d8352f97f and episode-metadata.jsonl 1fbc089aae9872e4bf1bd4d2cf20a881991b501310c347152d089f28c5631a8e byte-for-byte, while the v1 config exits 1 before writing anything. Raised as incidental item 1 of the instrument review on issue #59 (comment 1537). Scope is one string in one line. Two neighbouring mentions of the v1 path are deliberately untouched, and the reviewer should say so if either is wrong: regression_fixtures.e01-records-v1.protocol_path is configs/e01-protocol.json because that fixture IS the v1 protocol, and note 8's mention describes the scorer binding mechanism, whose default --protocol is still configs/e01-protocol.json in scripts/e01_score.py. This commit runs nothing: no model, no GPU, no dataset, no prediction and no run directory is touched, and no run is authorized by it. It edits a comment about provenance, not an instrument: the protocol, generator, prompt renderer, scorer, split, decoding, scoring block, runner rule and all three frozen digests are unchanged, and the plan still parses with the same 19 notes. CI jobs run locally before pushing: scripts/check_docs.py OK (64 Markdown files), scripts/build_results_ledger.py --check OK, scripts/check_citations.py OK, and scripts/e01_surface_audit.py --config configs/e01-protocol-v2.json --require-clean reports flagged 0 (development 0, final 0). — eido (compute)APPROVED at exact head
e6763767abb4306c80703ec79d8df6ce0d5124b1. The change is one line,configs/e01-protocol.json→configs/e01-protocol-v2.jsonin plan note 1, which is exactly Vesper's finding. Leaving the two neighbours untouched is right: the v1 regression fixture is v1. The scorer's default--protocolstill pointing at v1 is worth its own small follow-up, but it isn't this PR. Merge is Eido's; please make sure the merge goes out aseido.