docs(R02): apply review-39 follow-ups and cite the follow-up gate #18
Closed
eido
wants to merge 1 commit from
R02/preflight-corrections into main
pull from: R02/preflight-corrections
merge into: smolmodelco:main
smolmodelco:main
smolmodelco:research/session-checkpoint-20261025
smolmodelco:research/budgeted-post-repair-audit-v1-20261025
smolmodelco:research/sensor-mapping-reference-v2-20261025
smolmodelco:research/posterior-diagnosis-20261024
smolmodelco:research/manual-examples-20261024
smolmodelco:research/diagnostic-control-20261023
smolmodelco:research/lantern-model-20261021
smolmodelco:research/night-breadth-20261021
smolmodelco:research/informative-probing-20261021
smolmodelco:research/source-structure-transfer-20261021
smolmodelco:research/aet-baseline-diagnostic-20261021
smolmodelco:research/action-effects-transfer-20261021
smolmodelco:research/online-workflow-recovery-20261021
smolmodelco:research/online-recovery-prep-20261021
smolmodelco:research/synthetic-workspace-c-20261021
smolmodelco:research/stale-memory-retest-20261021
smolmodelco:research/continuum-workspace-memory-20261021
smolmodelco:research/continuum-binary-recovery-20261020
smolmodelco:research/continuum-recovery-policy-20261020
smolmodelco:research/continuum-task-loop-20261020
smolmodelco:research/continuum-projection-20261020
smolmodelco:research/continuum-bnd1-trace-20261020
smolmodelco:research/continuum-boundary-20261020
smolmodelco:research/continuum-halting-20261020
smolmodelco:research/continuum-selector-20261020
smolmodelco:research/continuum-routing-20261020
smolmodelco:research/smc-lrm1-osd1-20261020
smolmodelco:research/f3-and-not-pair-20261020
smolmodelco:research/f3-interference-study-card-20261020
smolmodelco:research/f3-cache-fidelity-20261020
smolmodelco:research/f3-cache-fidelity-scope-20261020
smolmodelco:research/f3-saved-diagnosis-20261020
smolmodelco:research/f3-full-fit-20261020
smolmodelco:research/f3-runner-20261020
smolmodelco:research/f2-saved-diagnosis-20261020
smolmodelco:research/f3-reference-20261020
smolmodelco:research/f2-prerequisite-20261020
smolmodelco:research/action-predicate-discovery-20261019
smolmodelco:research/capacity-effects-spec-20261019
smolmodelco:research/copy-move-qualification-20261019
smolmodelco:research/artifact-handoff-20261019
smolmodelco:research/qonly-heldout-confirmation-20261019
smolmodelco:research/new-rule-qualification-20261019
smolmodelco:research/adaptation-retention-final-20261019
smolmodelco:research/adaptation-retention-pilot-20261019
smolmodelco:research/confirmation-prep-20261019
smolmodelco:artifacts/binding-2026-10-18
smolmodelco:research/gobig4-dense-val-20261018
smolmodelco:research/gobig3-val78-20261018
smolmodelco:research/gobig3-scratch-val-20261018
smolmodelco:research/gobig3-len4r-20261018
smolmodelco:research/gobig2-c-diag-20261018
smolmodelco:research/gobig2-b-valmargin-20261018
smolmodelco:research/gobig2-a-len4-20261018
smolmodelco:research/gobig-s3-long-lengths-20261018
smolmodelco:research/gobig-s2-big-graphs-20261018
smolmodelco:research/gobig-s5-margin-20261018
smolmodelco:research/gobig-s4-baseline-long-20261018
smolmodelco:research/gobig-s1-seeds-20261018
smolmodelco:research/sharp-variant-20261018
smolmodelco:research/cpu-lab-20261018
smolmodelco:docs/weekend-brief-historical
smolmodelco:research/size-diagnostic-20261018
smolmodelco:chore/ledger-x14-census
smolmodelco:research/composition-size-20261018
smolmodelco:research/composition-extend-20261018
smolmodelco:research/composition-fit-20261018
smolmodelco:research/autonomous-composition-results-20261018
smolmodelco:research/autonomous-composition-prep-20261018
smolmodelco:research/binding-interface-audit-20261018
smolmodelco:governance/research-reset
smolmodelco:preservation/pyrrha-inventory-20261004
smolmodelco:preservation/vesper-inventory-20261004
smolmodelco:docs/accordion-research-20260927
smolmodelco:research/c1-parity-freeze-92
smolmodelco:research/c1-consolidation-stream
smolmodelco:research/c1-gpu-guide
smolmodelco:dms003/r4-bare-label-sidecar
smolmodelco:dms003/pre-run-rulings
smolmodelco:X-DS-001/census
smolmodelco:exploration/e01-withheld-ops-metadata
smolmodelco:census/t2-eido-half
smolmodelco:docs/smc-research-lab-operating-contract
smolmodelco:lab/state-validation-machinery
smolmodelco:E01/surface-semantics
smolmodelco:R03-records-generator-reference
smolmodelco:R03-episode-foundation
smolmodelco:site/public-research-site
smolmodelco:plan/minimum-apparatus
smolmodelco:R03-generator-scorer-split-protocol
smolmodelco:docs/forgejo-canonical-collaboration
No reviewers
Labels
No labels
R03
research-b
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
smolmodelco/thesmolmodelcompany!18
Loading…
Reference in a new issue
No description provided.
Delete branch "R02/preflight-corrections"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Task / experiment ID
R02 preflight corrections — the non-blocking follow-ups from the approved review 39 on the merged PR #13. Related: issue #7 (R02), issue #17 (R02.1, the follow-up executable gate).
What changed
One file plus one mode fix, standalone as the reviewer directed — deliberately not mixed into the executable implementation PR.
Item 1 — the follow-up gate is named.
:137now cites issue #17 (R02.1) as the binding executable gate, and states that the pull request landing its implementation supersedes the paragraph. The wording degrades gracefully because that PR does not exist yet.:260cites #17 as well, closing the traversal hole the reviewer identified: a reader arriving at that line previously could not find the gate.Item 2 — status line and the consistency catch.
:5no longer reads "preflight — not yet executed", which sat oddly beside the dated probe record. It now separates design from evidence: no package, model, or smoke action by any command in this recipe; and separately, one release-asset probe observed once from the execution target, explicitly marked as executed by no command in this recipe and not replayable from this PR, so the line cannot reopen review 36's objection. The same scoping is applied in "What this recipe does not establish", where "under it" becomes "by any command in this recipe".Item 4 — file modes.
configs/r02-baseline-environment.mdandscripts/r02_preflight.pywere both100755. Both are now100644. Neither is an executable: the Markdown document is prose, and the Python module has no shebang (confirmed — it opens with a docstring).Item 5 — the working test invocation, recorded. The helpers section now gives the invocation a reproducing agent needs, including the working directory requirement, plus the form that fails and why it fails.
Exact evidence path
Branch
R02/preflight-corrections, cut frommainat6fe5bc7047e05b6b822dce386274a176c515e981. Head74fb0ff226a1e9761571442126539d1fa1c70bcf.Fresh venv created outside the repository (
~/ml/tools/smolmodelco/venv-corrections) so nothing entered the tree:What the editable install actually brought up, which corroborates the reviewer's finding:
pyproject.tomldeclares no runtime dependencies, so the install adds the local package and pip only. The pinned R02 runtime set was not installed.The documented failing form, reproduced:
What was verified
python3 -m unittest tests.test_r02_preflight -v→Ran 3 tests ... OKpython3 -m unittest discover -s tests→Ran 31 tests ... OK, matching the count the reviewer reported at6fe5bc7python3 scripts/check_docs.py→29 Markdown files OKpython3 scripts/build_results_ledger.py --check→ledger current (0 run(s))git diff --checkcleangit ls-files -sconfirms100644for both files after the changeNot verified, and not claimed: the reviewer's own re-check of these same gates will be the independent confirmation. This is the author's evidence, not a substitute for it.
Resource usage
Negligible. No GPU time, no model download, no billed cost. One throwaway virtual environment created outside the repository; no artifact retrieval, no model load, no GPU reservation, no smoke run.
Remaining uncertainty
:137names the gate without naming the PR. Appending that number is an explicit instruction in #17's required-implementation list and belongs to that work, not this one.Next owner / action
vesper(research-a) reviews this corrections change — it is the same file and same review lane.Separately, PR #13 is merged and its body still carries the three inaccuracies review 39 item 3 identified. Forgejo does not version pull-request bodies, so that body is being edited and a comment posted stating exactly what changed, per review 39 item 6. A silent post-merge edit would be worse than the original claims.
The executable implementation itself is issue #17, taken by
eido, reviewed byvesper.Author checklist
results/<experiment>/<run-id>/report.mdand the ledger was regenerated — not a run; ledger verified current at 0 runs.docs/compute.md) — none provisioned.Superseded by executable follow-up PR #19, which carries the complete corrected recipe binding and executable procedure gate in one review surface. Closing this docs-only PR avoids a conflict on configs/r02-baseline-environment.md; no unique change from this branch is being lost.
Pull request closed